Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: src/parsing/parser.h

Issue 2164943002: Split NewScope into NewScope and NewScopeWithParent (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index 15fb310b030f67c87f5b5c947f81210a98dedfc3..a0606e5096d38b445282a7804db59f1bc95b1814 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -542,8 +542,9 @@ class ParserTraits {
ZoneList<Statement*>* body, bool accept_IN,
Type::ExpressionClassifier* classifier, int pos, bool* ok);
- V8_INLINE Scope* NewScope(Scope* parent_scope, ScopeType scope_type);
+ V8_INLINE Scope* NewScope(ScopeType scope_type);
V8_INLINE Scope* NewFunctionScope(FunctionKind kind);
+ V8_INLINE Scope* NewScopeWithParent(Scope* parent, ScopeType scope_type);
V8_INLINE void AddFormalParameter(ParserFormalParameters* parameters,
Expression* pattern,
@@ -1143,8 +1144,12 @@ bool ParserTraits::IsFutureStrictReserved(
return parser_->scanner()->IdentifierIsFutureStrictReserved(identifier);
}
-Scope* ParserTraits::NewScope(Scope* parent_scope, ScopeType scope_type) {
- return parser_->NewScope(parent_scope, scope_type);
+Scope* ParserTraits::NewScopeWithParent(Scope* parent, ScopeType scope_type) {
+ return parser_->NewScopeWithParent(parent, scope_type);
+}
+
+Scope* ParserTraits::NewScope(ScopeType scope_type) {
+ return parser_->NewScope(scope_type);
}
Scope* ParserTraits::NewFunctionScope(FunctionKind kind) {
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698