chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js - Issue 2164813003: Fix visible position calculation in accessible setSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2164813003: Fix visible position calculation in accessible setSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert ChromeVox workaround and update test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

index 07b29e4bfd9de8221fbb343220cf9ee1a7c9ad2b..4ec0925ceb125611205c9fe10defe69178bc1521 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

@@ -185,16 +185,6 @@ AutomationPredicate.leafOrStaticText = function(node) {

};

/**

- * Matches against all nodes that have selectable text.

- * @param {!AutomationNode} node

- * @return {boolean}

- */

-AutomationPredicate.text = function(node) {

- return node.role == RoleType.staticText ||

- node.role == RoleType.lineBreak;

-};

-/**

* Matches against nodes visited during object navigation. An object as

* defined below, are all nodes that are focusable or static text. When used in

* tree walking, it should visit all nodes that tab traversal would as well as