Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2164773002: Make `gn refs` look at script files. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make `gn refs` look at script files. Currently, `gn refs` would not look at the script files listed in action() and action_foreach() targets, so, for example `gn refs out/Default //tools/grit/grit.py` would return no references. This (a) is obviously incorrect, and (b) meant that analyze would not handle this case correctly and compiles would get skipped as a result. R=brettw@chromium.org BUG=627667 Committed: https://crrev.com/aca08753b705ef13f334c9f0aee6d44c217e4ad6 Cr-Commit-Position: refs/heads/master@{#406368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn/command_refs.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-19 19:24:07 UTC) #1
brettw
lgtm
4 years, 5 months ago (2016-07-19 19:26:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164773002/1
4 years, 5 months ago (2016-07-19 19:44:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 20:23:53 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 20:26:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aca08753b705ef13f334c9f0aee6d44c217e4ad6
Cr-Commit-Position: refs/heads/master@{#406368}

Powered by Google App Engine
This is Rietveld 408576698