Make `gn refs` handle files in data directories properly.

Make `gn refs` handle files in data directories properly.

If a target specified `data = [ "test/" ]` and you ran
`gn refs out/Default //foo //foo/test/bar.cc`, gn refs would
incorrectly think that nothing referenced bar.cc. This patch
fixes that.

R=brettw@chromium.org
BUG=628783
Committed: https://crrev.com/267b1de99ba7baf7150d4e8e1b9e42969c16c343
Cr-Commit-Position: refs/heads/master@{#406689}

[jam, 2016-07-19 20:53:37]

I'm not familiar with this code, but the patch doesn't look like it'll handle
//foo/test/bar/baz.cc?

[Dirk Pranke, 2016-07-19 21:45:54]

On 2016/07/19 20:53:37, jam wrote:
> I'm not familiar with this code, but the patch doesn't look like it'll handle
> //foo/test/bar/baz.cc?

Why wouldn't it?

cur_file = "//foo/test/"
file = "//foo/test/bar/baz.cc"
cur_file.size() = 11

strncmp("//foo/test/", "//foo/test/bar/baz.cc", 10) == 0, right?

[jam, 2016-07-20 17:03:28]

On 2016/07/19 21:45:54, Dirk Pranke wrote:
> On 2016/07/19 20:53:37, jam wrote:
> > I'm not familiar with this code, but the patch doesn't look like it'll
handle
> > //foo/test/bar/baz.cc?
> 
> Why wouldn't it?
> 
> cur_file = "//foo/test/"
> file = "//foo/test/bar/baz.cc"
> cur_file.size() = 11
> 
> strncmp("//foo/test/", "//foo/test/bar/baz.cc", 10) == 0, right?

oops, sorry I had these two variables mixed (the variable name is confusing to
someone not familiar with gn source!).

[brettw, 2016-07-20 17:52:14]

lgtm

https://codereview.chromium.org/2160383002/diff/1/tools/gn/command_refs.cc
File tools/gn/command_refs.cc (right):

https://codereview.chromium.org/2160383002/diff/1/tools/gn/command_refs.cc#ne...
tools/gn/command_refs.cc:147: !strncmp(cur_file.c_str(), file.value().c_str(),
cur_file.size() - 1))
How about
cur_file.back() == '/' &&
!base::StartsWith(file, cur_file, base::CompareCase::SENSITIVE);

[Dirk Pranke, 2016-07-20 21:24:31]

https://codereview.chromium.org/2160383002/diff/1/tools/gn/command_refs.cc
File tools/gn/command_refs.cc (right):

https://codereview.chromium.org/2160383002/diff/1/tools/gn/command_refs.cc#ne...
tools/gn/command_refs.cc:147: !strncmp(cur_file.c_str(), file.value().c_str(),
cur_file.size() - 1))
On 2016/07/20 17:52:14, brettw (ping after 24h) wrote:
> How about
> cur_file.back() == '/' &&
> !base::StartsWith(file, cur_file, base::CompareCase::SENSITIVE);

I figured there was some base routine for this but hadn't tracked it down. Will
change.

[Dirk Pranke, 2016-07-20 21:40:36]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-07-20 21:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2160383002/#ps20001
(title: "use base::StartsWith")

[commit-bot: I haz the power, 2016-07-20 21:41:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:22:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 22:24:03]

Description was changed from

==========
Make `gn refs` handle files in data directories properly.

If a target specified `data = [ "test/" ]` and you ran
`gn refs out/Default //foo //foo/test/bar.cc`, gn refs would
incorrectly think that nothing referenced bar.cc. This patch
fixes that.

R=brettw@chromium.org
BUG=628783
==========

to

==========
Make `gn refs` handle files in data directories properly.

If a target specified `data = [ "test/" ]` and you ran
`gn refs out/Default //foo //foo/test/bar.cc`, gn refs would
incorrectly think that nothing referenced bar.cc. This patch
fixes that.

R=brettw@chromium.org
BUG=628783

Committed: https://crrev.com/267b1de99ba7baf7150d4e8e1b9e42969c16c343
Cr-Commit-Position: refs/heads/master@{#406689}
==========

[commit-bot: I haz the power, 2016-07-20 22:24:04]

Patchset 2 (id:??) landed as
https://crrev.com/267b1de99ba7baf7150d4e8e1b9e42969c16c343
Cr-Commit-Position: refs/heads/master@{#406689}