Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2164763003: remove dead methods now that we use specials exclusively for imagefilters (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove dead methods now that we use specials exclusively for imagefilters BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164763003 Committed: https://skia.googlesource.com/skia/+/cf5c846b4176da82bccb5d5b45788bf0d45a8dd8

Patch Set 1 #

Patch Set 2 : rm drawSpriteWithFilter #

Patch Set 3 : remove internal_getBM/fromBM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -82 lines) Patch
M include/core/SkDevice.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 1 chunk +0 lines, -30 lines 0 comments Download
M src/core/SkSpecialImage.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 2 chunks +5 lines, -23 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +2 lines, -11 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
reed1
ptal
4 years, 5 months ago (2016-07-20 19:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164763003/40001
4 years, 5 months ago (2016-07-20 19:03:48 UTC) #5
robertphillips
lgtm
4 years, 5 months ago (2016-07-20 19:08:35 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:28:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cf5c846b4176da82bccb5d5b45788bf0d45a8dd8

Powered by Google App Engine
This is Rietveld 408576698