Change Dismiss button to Discard and cancel download

chrome/app/nibs/DownloadItem.xib

Index: chrome/app/nibs/DownloadItem.xib
diff --git a/chrome/app/nibs/DownloadItem.xib b/chrome/app/nibs/DownloadItem.xib
index abf5571a892438fcca032db023b7903a5263199b..9b6ebb7aefbe0f772a23c4f3b048f154ba468e2a 100644
--- a/chrome/app/nibs/DownloadItem.xib
+++ b/chrome/app/nibs/DownloadItem.xib
@@ -93,12 +93,12 @@
                                     <button verticalHuggingPriority="750" id="106">
                                         <rect key="frame" x="5" y="16" width="110" height="28"/>
                                         <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
-                                        <buttonCell key="cell" type="push" title="^IDS_DISMISS_DOWNLOAD" bezelStyle="rounded" alignment="center" controlSize="small" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="109">
+                                        <buttonCell key="cell" type="push" title="^IDS_DISCARD_DOWNLOAD" bezelStyle="rounded" alignment="center" controlSize="small" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="109">
                                             <behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
                                             <font key="font" metaFont="smallSystem"/>
                                         </buttonCell>
                                         <connections>
-                                            <action selector="dismissMaliciousDownload:" target="-2" id="114"/>
+                                            <action selector="discardDownload:" target="-2" id="114"/>

[Robert Sesek, 2016/07/20 18:37:11]

This is a method name but it hasn't been renamed in code. Did you test this?

[Jialiu Lin, 2016/07/20 19:05:33]

Yes, tested on Mac build. dismissMaliciousDownload is an existing function:
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/download/downloa...

[Robert Sesek, 2016/07/20 19:57:58]

Right, I was expecting dismissMaliciousDownload: to either be renamed in the
.h/mm file or removed. It looks like the XIB was the only caller.

[Jialiu Lin, 2016/07/20 20:05:59]

Oops, mistake in my previous reply. I actually meant "discardDownload" is an
existing function. 
And you're right, "dissmissMaliciousDownload" function is no longer needed.
Removed it from download_item_controller.h/mm

                                         </connections>
                                     </button>
                                     <button horizontalHuggingPriority="750" verticalHuggingPriority="750" id="107">