Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Side by Side Diff: chrome/app/nibs/DownloadItem.xib

Issue 2164723002: Change Dismiss button to Discard and cancel download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Download Item View on Mac Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8" standalone="no"?> 1 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
2 <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersio n="5056" systemVersion="13F1077" targetRuntime="MacOSX.Cocoa" propertyAccessCont rol="none"> 2 <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersio n="5056" systemVersion="13F1077" targetRuntime="MacOSX.Cocoa" propertyAccessCont rol="none">
3 <dependencies> 3 <dependencies>
4 <deployment version="1060" identifier="macosx"/> 4 <deployment version="1060" identifier="macosx"/>
5 <development version="5100" identifier="xcode"/> 5 <development version="5100" identifier="xcode"/>
6 <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="505 6"/> 6 <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="505 6"/>
7 </dependencies> 7 </dependencies>
8 <objects> 8 <objects>
9 <customObject id="-2" userLabel="File's Owner" customClass="DownloadItem Controller"> 9 <customObject id="-2" userLabel="File's Owner" customClass="DownloadItem Controller">
10 <connections> 10 <connections>
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 </button> 86 </button>
87 </subviews> 87 </subviews>
88 </customView> 88 </customView>
89 <customView id="105" customClass="GTMWidthBasedTweak er"> 89 <customView id="105" customClass="GTMWidthBasedTweak er">
90 <rect key="frame" x="295" y="-12" width="152" he ight="57"/> 90 <rect key="frame" x="295" y="-12" width="152" he ight="57"/>
91 <autoresizingMask key="autoresizingMask" flexibl eMaxX="YES" flexibleMaxY="YES"/> 91 <autoresizingMask key="autoresizingMask" flexibl eMaxX="YES" flexibleMaxY="YES"/>
92 <subviews> 92 <subviews>
93 <button verticalHuggingPriority="750" id="10 6"> 93 <button verticalHuggingPriority="750" id="10 6">
94 <rect key="frame" x="5" y="16" width="11 0" height="28"/> 94 <rect key="frame" x="5" y="16" width="11 0" height="28"/>
95 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/> 95 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
96 <buttonCell key="cell" type="push" title ="^IDS_DISMISS_DOWNLOAD" bezelStyle="rounded" alignment="center" controlSize="sm all" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="109"> 96 <buttonCell key="cell" type="push" title ="^IDS_DISCARD_DOWNLOAD" bezelStyle="rounded" alignment="center" controlSize="sm all" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="109">
97 <behavior key="behavior" pushIn="YES " lightByBackground="YES" lightByGray="YES"/> 97 <behavior key="behavior" pushIn="YES " lightByBackground="YES" lightByGray="YES"/>
98 <font key="font" metaFont="smallSyst em"/> 98 <font key="font" metaFont="smallSyst em"/>
99 </buttonCell> 99 </buttonCell>
100 <connections> 100 <connections>
101 <action selector="dismissMaliciousDo wnload:" target="-2" id="114"/> 101 <action selector="discardDownload:" target="-2" id="114"/>
Robert Sesek 2016/07/20 18:37:11 This is a method name but it hasn't been renamed i
Jialiu Lin 2016/07/20 19:05:33 Yes, tested on Mac build. dismissMaliciousDownload
Robert Sesek 2016/07/20 19:57:58 Right, I was expecting dismissMaliciousDownload: t
Jialiu Lin 2016/07/20 20:05:59 Oops, mistake in my previous reply. I actually mea
102 </connections> 102 </connections>
103 </button> 103 </button>
104 <button horizontalHuggingPriority="750" vert icalHuggingPriority="750" id="107"> 104 <button horizontalHuggingPriority="750" vert icalHuggingPriority="750" id="107">
105 <rect key="frame" x="113" y="18" width=" 25" height="23"/> 105 <rect key="frame" x="113" y="18" width=" 25" height="23"/>
106 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/> 106 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
107 <buttonCell key="cell" type="disclosure" bezelStyle="roundedDisclosure" image="6C8999CD-78E8-4413-A018-B560C67F76D1" ima gePosition="only" alignment="center" controlSize="small" borderStyle="border" im ageScaling="proportionallyDown" inset="2" id="108"> 107 <buttonCell key="cell" type="disclosure" bezelStyle="roundedDisclosure" image="6C8999CD-78E8-4413-A018-B560C67F76D1" ima gePosition="only" alignment="center" controlSize="small" borderStyle="border" im ageScaling="proportionallyDown" inset="2" id="108">
108 <behavior key="behavior" pushIn="YES " lightByBackground="YES" lightByGray="YES"/> 108 <behavior key="behavior" pushIn="YES " lightByBackground="YES" lightByGray="YES"/>
109 <font key="font" metaFont="smallSyst em"/> 109 <font key="font" metaFont="smallSyst em"/>
110 <string key="keyEquivalent">s</strin g> 110 <string key="keyEquivalent">s</strin g>
111 <modifierMask key="keyEquivalentModi fierMask" command="YES"/> 111 <modifierMask key="keyEquivalentModi fierMask" command="YES"/>
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 cFhOU09iamVjdNIlJi0uV05TQXJyYXmiLSvSJSYwMV5OU011dGFibGVBcnJheaMwLSvTMzQKNTY3V05T 172 cFhOU09iamVjdNIlJi0uV05TQXJyYXmiLSvSJSYwMV5OU011dGFibGVBcnJheaMwLSvTMzQKNTY3V05T
173 V2hpdGVcTlNDb2xvclNwYWNlRDAgMAAQA4AM0iUmOTpXTlNDb2xvcqI5K9IlJjw9V05TSW1hZ2WiPCtf 173 V2hpdGVcTlNDb2xvclNwYWNlRDAgMAAQA4AM0iUmOTpXTlNDb2xvcqI5K9IlJjw9V05TSW1hZ2WiPCtf
174 EA9OU0tleWVkQXJjaGl2ZXLRQEFUcm9vdIABAAgAEQAaACMALQAyADcARgBMAFcAXgBlAHIAeQCBAIMA 174 EA9OU0tleWVkQXJjaGl2ZXLRQEFUcm9vdIABAAgAEQAaACMALQAyADcARgBMAFcAXgBlAHIAeQCBAIMA
175 hQCKAIwAjgCVAJoApQCnAKkAqwCwALMAtQC3ALkAuwDAANcA2QDbCU8JVAlfCWgJewl/CZIJnQmmCasJ 175 hQCKAIwAjgCVAJoApQCnAKkAqwCwALMAtQC3ALkAuwDAANcA2QDbCU8JVAlfCWgJewl/CZIJnQmmCasJ
176 swm2CbsJygnOCdUJ3QnqCe8J8QnzCfgKAAoDCggKEAoTCiUKKAotAAAAAAAAAgEAAAAAAAAAQgAAAAAA 176 swm2CbsJygnOCdUJ3QnqCe8J8QnzCfgKAAoDCggKEAoTCiUKKAotAAAAAAAAAgEAAAAAAAAAQgAAAAAA
177 AAAAAAAAAAAACi8 177 AAAAAAAAAAAACi8
178 </mutableData> 178 </mutableData>
179 </image> 179 </image>
180 </resources> 180 </resources>
181 </document> 181 </document>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698