Vendor requests.

Vendor requests.

We had previously manually done this, but the small script dnj@ wrote makes this
much easier.

Committed: https://github.com/luci/recipes-py/commit/ece774fd870a6b883cdd0f541a686ec3ca581613

[martiniss, 2016-07-20 01:15:54]

martiniss@chromium.org changed reviewers:
+ dnj@chromium.org, iannucci@chromium.org, phajdan.jr@chromium.org

[martiniss, 2016-07-20 01:15:57]

PTAL

[Vadim Sh., 2016-07-20 01:20:18]

vadimsh@chromium.org changed reviewers:
+ vadimsh@chromium.org

[Vadim Sh., 2016-07-20 01:20:19]

this isn't going to work

*.so here are
1) Linux only.
2) Link to specific versions of libc and other dynamic libraries. They would
work only on Ubuntu version they were build on.

In general, it is not possible to vendor python modules with C extensions. It is
better to do something similar to what we do in infra/ENV (~= vendor wheels for
each individual platform and bootstrap a virtual env with the wheels installed
there).

[dnj (Google), 2016-07-20 01:30:54]

On 2016/07/20 01:20:19, Vadim Sh. wrote:
> this isn't going to work
> 
> *.so here are
> 1) Linux only.
> 2) Link to specific versions of libc and other dynamic libraries. They would
> work only on Ubuntu version they were build on.
> 
> In general, it is not possible to vendor python modules with C extensions. It
is
> better to do something similar to what we do in infra/ENV (~= vendor wheels
for
> each individual platform and bootstrap a virtual env with the wheels installed
> there).

100% what Vadim said. An additional option is to execute "pip install" in a
virtualenv or something, dunno if that fits your use case here.

[martiniss, 2016-07-20 19:24:36]

Ok, I had tested it on a mac bot, but I guess it wasn't calling the compiled
code. 

I've put the crypto stuff in the deps.pyl we already have.

[dnj, 2016-07-20 21:34:07]

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
File bootstrap/update_vendoring.py (right):

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
bootstrap/update_vendoring.py:253: _VendoredPipPackage(
You don't still want this then, right?

[martiniss, 2016-07-20 21:39:27]

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
File bootstrap/update_vendoring.py (right):

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
bootstrap/update_vendoring.py:253: _VendoredPipPackage(
On 2016/07/20 at 21:34:07, dnj wrote:
> You don't still want this then, right?

No, I still do. We still want a vendored requests, and this vendoring is better
than the copy pasting we did before. If you look at the CL, you can see it
deletes tests and documentation and stuff, which we don't need

[dnj, 2016-07-20 21:59:44]

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/deps.pyl
File bootstrap/deps.pyl (right):

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/deps.pyl#newc...
bootstrap/deps.pyl:29: 'requests': {
But don't you install requests independently here?

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
File bootstrap/update_vendoring.py (right):

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
bootstrap/update_vendoring.py:253: _VendoredPipPackage(
On 2016/07/20 21:39:27, martiniss wrote:
> On 2016/07/20 at 21:34:07, dnj wrote:
> > You don't still want this then, right?
> 
> No, I still do. We still want a vendored requests, and this vendoring is
better
> than the copy pasting we did before. If you look at the CL, you can see it
> deletes tests and documentation and stuff, which we don't need

So you are virtualenv-bootstrapping "requests", but also vendoring?

Do you delete doc/tests after vendoring, or was that just part of the previous
vendoring scheme and this method doesn't include them?If the former is the case,
you should add that to the script.

[martiniss, 2016-07-20 22:26:21]

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/deps.pyl
File bootstrap/deps.pyl (right):

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/deps.pyl#newc...
bootstrap/deps.pyl:29: 'requests': {
On 2016/07/20 at 21:59:44, dnj wrote:
> But don't you install requests independently here?

Oh, whoops. I don't want this.

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
File bootstrap/update_vendoring.py (right):

https://codereview.chromium.org/2164713003/diff/30001/bootstrap/update_vendor...
bootstrap/update_vendoring.py:253: _VendoredPipPackage(
On 2016/07/20 at 21:59:44, dnj wrote:
> On 2016/07/20 21:39:27, martiniss wrote:
> > On 2016/07/20 at 21:34:07, dnj wrote:
> > > You don't still want this then, right?
> > 
> > No, I still do. We still want a vendored requests, and this vendoring is
better
> > than the copy pasting we did before. If you look at the CL, you can see it
> > deletes tests and documentation and stuff, which we don't need
> 
> So you are virtualenv-bootstrapping "requests", but also vendoring?
Didn't mean to. No virtualenv, only vendor.

> 
> Do you delete doc/tests after vendoring, or was that just part of the previous
vendoring scheme and this method doesn't include them?If the former is the case,
you should add that to the script.

No, it was part of the previous vendoring scheme (git clone requests.git).

[dnj, 2016-07-20 23:14:01]

lgtm, careful when you land

[martiniss, 2016-07-21 00:54:06]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:54:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:58:23]

Description was changed from

==========
Vendor requests.

We had previously manually done this, but the small script dnj@ wrote makes this
much easier.
==========

to

==========
Vendor requests.

We had previously manually done this, but the small script dnj@ wrote makes this
much easier.

Committed:
https://github.com/luci/recipes-py/commit/ece774fd870a6b883cdd0f541a686ec3ca5...
==========

[commit-bot: I haz the power, 2016-07-21 00:58:25]

Committed patchset #4 (id:50001) as
https://github.com/luci/recipes-py/commit/ece774fd870a6b883cdd0f541a686ec3ca5...