Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: runtime/vm/isolate_reload.h

Issue 2164703003: Fix for use-after-free of reload context (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: s/test_mode/dont_delete_reload_context/, simplifications Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/isolate_reload.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload.h
diff --git a/runtime/vm/isolate_reload.h b/runtime/vm/isolate_reload.h
index 3d362783600d9cbeac940c42f6205c24e9201d8a..8d0c5934304e20dc576056f35da0a602522a7833 100644
--- a/runtime/vm/isolate_reload.h
+++ b/runtime/vm/isolate_reload.h
@@ -46,7 +46,7 @@ class UpdateClassesVisitor;
class IsolateReloadContext {
public:
- explicit IsolateReloadContext(Isolate* isolate, bool test_mode = false);
+ explicit IsolateReloadContext(Isolate* isolate);
~IsolateReloadContext();
void StartReload();
@@ -63,7 +63,6 @@ class IsolateReloadContext {
bool has_error() const { return has_error_; }
RawError* error() const { return error_; }
- bool test_mode() const { return test_mode_; }
static bool IsSameField(const Field& a, const Field& b);
static bool IsSameLibrary(const Library& a_lib, const Library& b_lib);
@@ -130,7 +129,6 @@ class IsolateReloadContext {
int64_t start_time_micros_;
Isolate* isolate_;
- bool test_mode_;
bool has_error_;
intptr_t saved_num_cids_;
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/isolate_reload.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698