runtime/vm/isolate_reload.cc - Issue 2164703003: Fix for use-after-free of reload context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate_reload.cc

Issue 2164703003: Fix for use-after-free of reload context (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: s/test_mode/dont_delete_reload_context/, simplifications Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate_reload.cc

diff --git a/runtime/vm/isolate_reload.cc b/runtime/vm/isolate_reload.cc

index 7f8018b69d5b73cd745f61645bd511b936d5a80e..75102c9d1f089b71142cf02708a03df53f6d9a95 100644

--- a/runtime/vm/isolate_reload.cc

+++ b/runtime/vm/isolate_reload.cc

@@ -177,10 +177,9 @@ bool IsolateReloadContext::IsSameLibrary(

}

-IsolateReloadContext::IsolateReloadContext(Isolate* isolate, bool test_mode)

+IsolateReloadContext::IsolateReloadContext(Isolate* isolate)

: start_time_micros_(OS::GetCurrentMonotonicMicros()),

isolate_(isolate),

- test_mode_(test_mode),

has_error_(false),

saved_num_cids_(-1),

saved_class_table_(NULL),

« no previous file with comments | « runtime/vm/isolate_reload.h ('k') | runtime/vm/unit_test.cc » ('j') | no next file with comments »