Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2662)

Unified Diff: chrome/browser/resources/ntp4/tile_page.js

Issue 2164693002: [WebUI] ClosureCompile cr.ui.DragWrapper, create a real handler class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove prototypical lies Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/tile_page.js
diff --git a/chrome/browser/resources/ntp4/tile_page.js b/chrome/browser/resources/ntp4/tile_page.js
index 8f37a1f8248edd07b475f0f9ab63b878acf94959..ca032caa2a22c2196ef3b2f7ab8c1a4dfbebe2a5 100644
--- a/chrome/browser/resources/ntp4/tile_page.js
+++ b/chrome/browser/resources/ntp4/tile_page.js
@@ -359,6 +359,7 @@ cr.define('ntp', function() {
* of the tile grid.
* @constructor
* @extends {HTMLDivElement}
+ * @implements {cr.ui.DragWrapperDelegate}
*/
function TilePage(gridValues) {
var el = cr.doc.createElement('div');
@@ -1145,18 +1146,12 @@ cr.define('ntp', function() {
return this.dragWrapper_.isCurrentDragTarget;
},
- /**
- * Thunk for dragleave events fired on |tileGrid_|.
- * @param {Event} e A MouseEvent for the drag.
- */
+ /** @override */
doDragLeave: function(e) {
this.cleanupDrag();
},
- /**
- * Performs all actions necessary when a drag enters the tile page.
- * @param {Event} e A mouseover event for the drag enter.
- */
+ /** @override */
doDragEnter: function(e) {
// Applies the mask so doppleganger tiles disappear into the fog.
this.updateMask_();
@@ -1175,11 +1170,7 @@ cr.define('ntp', function() {
this.doDragOver(e);
},
- /**
- * Performs all actions necessary when the user moves the cursor during
- * a drag over the tile page.
- * @param {Event} e A mouseover event for the drag over.
- */
+ /** @override */
doDragOver: function(e) {
e.preventDefault();
@@ -1190,10 +1181,7 @@ cr.define('ntp', function() {
this.updateDropIndicator_(newDragIndex);
},
- /**
- * Performs all actions necessary when the user completes a drop.
- * @param {Event} e A mouseover event for the drag drop.
- */
+ /** @override */
doDrop: function(e) {
e.stopPropagation();
e.preventDefault();

Powered by Google App Engine
This is Rietveld 408576698