Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4925)

Unified Diff: chrome/browser/resources/ntp4/trash.js

Issue 2164693002: [WebUI] ClosureCompile cr.ui.DragWrapper, create a real handler class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove prototypical lies Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/trash.js
diff --git a/chrome/browser/resources/ntp4/trash.js b/chrome/browser/resources/ntp4/trash.js
index 463232cb425dc196141b1f3a017b6fa28d69d466..510348a10f1ec200f9c6b41fb6ba4f9661b31008 100644
--- a/chrome/browser/resources/ntp4/trash.js
+++ b/chrome/browser/resources/ntp4/trash.js
@@ -12,6 +12,8 @@ cr.define('ntp', function() {
/**
* @constructor
+ * @extends {HTMLDivElement}
+ * @implements {cr.ui.DragWrapperDelegate}
*/
function Trash(trash) {
trash.__proto__ = Trash.prototype;
@@ -39,10 +41,7 @@ cr.define('ntp', function() {
return tile.firstChild.canBeRemoved();
},
- /**
- * Drag over handler.
- * @param {Event} e The drag event.
- */
+ /** @override */
doDragOver: function(e) {
ntp.getCurrentlyDraggingTile().dragClone.classList.add(
'hovering-on-trash');
@@ -50,18 +49,12 @@ cr.define('ntp', function() {
e.preventDefault();
},
- /**
- * Drag enter handler.
- * @param {Event} e The drag event.
- */
+ /** @override */
doDragEnter: function(e) {
this.doDragOver(e);
},
- /**
- * Drop handler.
- * @param {Event} e The drag event.
- */
+ /** @override */
doDrop: function(e) {
e.preventDefault();
@@ -70,10 +63,7 @@ cr.define('ntp', function() {
tile.landedOnTrash = true;
},
- /**
- * Drag leave handler.
- * @param {Event} e The drag event.
- */
+ /** @override */
doDragLeave: function(e) {
ntp.getCurrentlyDraggingTile().dragClone.classList.remove(
'hovering-on-trash');

Powered by Google App Engine
This is Rietveld 408576698