Make allocator shim the default for Windows.

Make allocator shim the default for Windows release builds that link statically with the CRT.

BUG=550886
Committed: https://crrev.com/043dbae25c3523a26292c4e9ec001ca14e66ea69
Cr-Commit-Position: refs/heads/master@{#412220}

[Sigurður Ásgeirsson, 2016-07-19 15:44:30]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 15:44:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 15:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 15:55:25]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Sigurður Ásgeirsson, 2016-07-19 16:55:16]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 16:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2016-07-19 17:13:23]

Description was changed from

==========
Make allocator shim the default for Windows.

BUG=
==========

to

==========
Make allocator shim the default for Windows.

BUG=550886
==========

[commit-bot: I haz the power, 2016-07-19 17:44:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:44:37]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2016-07-21 14:49:00]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 14:49:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 15:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 15:48:32]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2016-08-10 15:50:29]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 15:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:54:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Sigurður Ásgeirsson, 2016-08-15 15:11:22]

Description was changed from

==========
Make allocator shim the default for Windows.

BUG=550886
==========

to

==========
Make allocator shim the default for Windows release builds that link statically
with the CRT.

BUG=550886
==========

[Sigurður Ásgeirsson, 2016-08-15 15:11:22]

siggi@chromium.org changed reviewers:
+ primiano@chromium.org, scottmg@chromium.org, wfh@chromium.org

[Sigurður Ásgeirsson, 2016-08-15 15:12:50]

Hey guys,

I've reproed and cleaned up the problems Chris found in his attempt to land this
(https://codereview.chromium.org/2183093002). Try this again?
Primiano and Will for content, Scott for owners pretty please?

Siggi

[scottmg, 2016-08-15 15:40:39]

lgtm

[Sigurður Ásgeirsson, 2016-08-15 15:52:13]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 15:52:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 17:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:39:25]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2016-08-15 18:17:00]

lgtm - we haven't had a debug shim since we changed to VS2015 anyway, and
primiano seemed fine with that.

[Sigurður Ásgeirsson, 2016-08-16 12:47:47]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2016-08-16 12:48:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 12:51:07]

Description was changed from

==========
Make allocator shim the default for Windows release builds that link statically
with the CRT.

BUG=550886
==========

to

==========
Make allocator shim the default for Windows release builds that link statically
with the CRT.

BUG=550886
==========

[commit-bot: I haz the power, 2016-08-16 12:51:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-16 12:53:16]

Description was changed from

==========
Make allocator shim the default for Windows release builds that link statically
with the CRT.

BUG=550886
==========

to

==========
Make allocator shim the default for Windows release builds that link statically
with the CRT.

BUG=550886

Committed: https://crrev.com/043dbae25c3523a26292c4e9ec001ca14e66ea69
Cr-Commit-Position: refs/heads/master@{#412220}
==========

[commit-bot: I haz the power, 2016-08-16 12:53:17]

Patchset 5 (id:??) landed as
https://crrev.com/043dbae25c3523a26292c4e9ec001ca14e66ea69
Cr-Commit-Position: refs/heads/master@{#412220}

[Will Harris, 2016-08-16 15:12:10]

🎆

[ukai, 2016-08-17 02:06:18]

failing with clang-cl.

https://build.chromium.org/p/chromium.fyi/builders/CrWinClangGoma/builds/1867...

FAILED: obj/base/allocator/unified_allocator_shim/allocator_shim.obj 
E:\b\c\cipd\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/base/allocator/unified_allocator_shim/allocator_shim.obj.rsp /c
../../base/allocator/allocator_shim.cc
/Foobj/base/allocator/unified_allocator_shim/allocator_shim.obj
/Fd"obj/base/allocator/unified_allocator_shim_cc.pdb"
../../base/allocator/allocator_shim.cc(37,18):  error: unused variable
'g_new_handler_lock' [-Werror,-Wunused-variable]
subtle::Atomic32 g_new_handler_lock = 0;
                 ^
1 error generated.

[Sigurður Ásgeirsson, 2016-08-17 13:31:52]

Fixed by Hans at https://codereview.chromium.org/2138173002.

On Tue, Aug 16, 2016 at 10:06 PM <ukai@chromium.org> wrote:

> failing with clang-cl.
>
>
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClangGoma/builds/1867...
>
> FAILED: obj/base/allocator/unified_allocator_shim/allocator_shim.obj
> E:\b\c\cipd\goma/gomacc.exe
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC
> @obj/base/allocator/unified_allocator_shim/allocator_shim.obj.rsp /c
> ../../base/allocator/allocator_shim.cc
> /Foobj/base/allocator/unified_allocator_shim/allocator_shim.obj
> /Fd"obj/base/allocator/unified_allocator_shim_cc.pdb"
> ../../base/allocator/allocator_shim.cc(37,18): error: unused variable
> 'g_new_handler_lock' [-Werror,-Wunused-variable]
> subtle::Atomic32 g_new_handler_lock = 0;
> ^
> 1 error generated.
>
> https://codereview.chromium.org/2164653002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Primiano Tucci (use gerrit), 2016-08-22 10:43:57]

Woot, it did stick this time? (slowly catching up emails post vacations)

[Sigurður Ásgeirsson, 2016-08-22 17:29:36]

Yups, seems to have stuck. Needed a couple of follow-up tweaks to fix this
and that, but hasn't been reverted yet, and crashes from the field are
certainly going through the shim :).

On Mon, Aug 22, 2016 at 6:43 AM <primiano@chromium.org> wrote:

> Woot, it did stick this time? (slowly catching up emails post vacations)
>
> https://codereview.chromium.org/2164653002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.