Make allocator shim the default for Windows.

Make allocator shim the default for Windows.

BUG=550886
patch from issue 2164653002 at patchset 40001 (http://crrev.com/2164653002#ps40001)

Committed: https://crrev.com/60292df5e4ed2fb3edd2c6efe32d6944ab059696
Cr-Commit-Position: refs/heads/master@{#407915}

[chrisha, 2016-07-26 16:00:51]

Description was changed from

==========
cd # Enter a description of the change.
Make allocator shim the default for Windows.

BUG=550886

patch from issue 2164653002 at patchset 40001
(http://crrev.com/2164653002#ps40001)
==========

to

==========
Make allocator shim the default for Windows.

BUG=550886

patch from issue 2164653002 at patchset 40001
(http://crrev.com/2164653002#ps40001)
==========

[chrisha, 2016-07-26 16:00:51]

chrisha@chromium.org changed reviewers:
+ brettw@chromium.org, primiano@chromium.org, wfh@chromium.org

[chrisha, 2016-07-26 16:01:41]

PTAL?

As per Siggi's email last week, we're going to flip the switch and see if this
sticks. I fully expect to see some strange things happen on some far flung bots,
as Primiano warned from previous experience.

[Will Harris, 2016-07-26 16:13:34]

:shrug: many bots went red to bring you this CL? lgtm, until it's not, then
revert it.

[brettw, 2016-07-26 18:17:50]

lgtm

[chrisha, 2016-07-26 18:57:51]

The CQ bit was checked by chrisha@chromium.org

[commit-bot: I haz the power, 2016-07-26 18:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-07-26 20:04:32]

LGTM may the force be with you.

[commit-bot: I haz the power, 2016-07-26 21:11:25]

Description was changed from

==========
Make allocator shim the default for Windows.

BUG=550886

patch from issue 2164653002 at patchset 40001
(http://crrev.com/2164653002#ps40001)
==========

to

==========
Make allocator shim the default for Windows.

BUG=550886

patch from issue 2164653002 at patchset 40001
(http://crrev.com/2164653002#ps40001)
==========

[commit-bot: I haz the power, 2016-07-26 21:11:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 21:13:30]

Description was changed from

==========
Make allocator shim the default for Windows.

BUG=550886

patch from issue 2164653002 at patchset 40001
(http://crrev.com/2164653002#ps40001)
==========

to

==========
Make allocator shim the default for Windows.

BUG=550886

patch from issue 2164653002 at patchset 40001
(http://crrev.com/2164653002#ps40001)

Committed: https://crrev.com/60292df5e4ed2fb3edd2c6efe32d6944ab059696
Cr-Commit-Position: refs/heads/master@{#407915}
==========

[commit-bot: I haz the power, 2016-07-26 21:13:30]

Patchset 1 (id:??) landed as
https://crrev.com/60292df5e4ed2fb3edd2c6efe32d6944ab059696
Cr-Commit-Position: refs/heads/master@{#407915}

[robliao, 2016-07-27 02:59:32]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2187473005/ by robliao@chromium.org.

The reason for reverting is: Causes Nacl to assert _CrtIsValidHeapPointer(block)
and then subsequently hang browser_tests.

First failure:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

PPAPINaClNewlibTest.MessageHandler
ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOriginCORSCredentials
PPAPINaClNewlibTest.NetAddressPrivate
ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOrigin
PPAPINaClNewlibTest.NetworkMonitor
And more..

[Primiano Tucci (use gerrit), 2016-07-27 12:17:28]

On 2016/07/27 02:59:32, robliao wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2187473005/ by mailto:robliao@chromium.org.

Told ya, these shim things never stick at the first attempt :P

[chrisha, 2016-07-27 13:27:03]

Yeah, fully expected some strange failures :)

On Wed, 27 Jul 2016 at 08:17 <primiano@chromium.org> wrote:

> On 2016/07/27 02:59:32, robliao wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2187473005/ by mailto:
> robliao@chromium.org.
>
> Told ya, these shim things never stick at the first attempt :P
>
> https://codereview.chromium.org/2183093002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.