Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2164633002: [runtime] temporarily transform IsContext check from DHECK to CHECK (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] temporarily transform IsContext check from DCHECK to CHECK We are enabling this trial on canary to see if we can flush out some missing context restores. BUG= Committed: https://crrev.com/ec94ad400dc257af396efa3b1899bc3168347d82 Cr-Commit-Position: refs/heads/master@{#37875}

Patch Set 1 #

Patch Set 2 : adding todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M src/arguments.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/builtins/builtins-utils.h View 1 1 chunk +25 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Camillo Bruni
PTAL
4 years, 5 months ago (2016-07-19 15:00:40 UTC) #2
Jakob Kummerow
lgtm
4 years, 5 months ago (2016-07-19 15:02:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164633002/20001
4 years, 5 months ago (2016-07-19 15:03:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 15:25:48 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ec94ad400dc257af396efa3b1899bc3168347d82 Cr-Commit-Position: refs/heads/master@{#37875}
4 years, 5 months ago (2016-07-19 15:26:25 UTC) #9
Camillo Bruni
4 years, 3 months ago (2016-09-01 12:30:36 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2303543003/ by cbruni@chromium.org.

The reason for reverting is: There have been no more occurrences of this on dev
/ beta so we can convert the CHECK back to DCHECK..

Powered by Google App Engine
This is Rietveld 408576698