Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/arguments.h

Issue 2164633002: [runtime] temporarily transform IsContext check from DHECK to CHECK (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: adding todo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arguments.h
diff --git a/src/arguments.h b/src/arguments.h
index ca24a794a134bba2e38ea1729fa87a00186f6366..34fbca4feacda2ca3b7eec59b054b107bb32c5b4 100644
--- a/src/arguments.h
+++ b/src/arguments.h
@@ -81,6 +81,7 @@ double ClobberDoubleRegisters(double x1, double x2, double x3, double x4);
// TODO(cbruni): add global flag to check whether any tracing events have been
// enabled.
+// TODO(cbruni): Convert the IsContext CHECK back to a DCHECK.
#define RUNTIME_FUNCTION_RETURNS_TYPE(Type, Name) \
static INLINE(Type __RT_impl_##Name(Arguments args, Isolate* isolate)); \
\
@@ -94,7 +95,7 @@ double ClobberDoubleRegisters(double x1, double x2, double x3, double x4);
} \
\
Type Name(int args_length, Object** args_object, Isolate* isolate) { \
- DCHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \
+ CHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \
CLOBBER_DOUBLE_REGISTERS(); \
if (FLAG_runtime_call_stats) { \
return Stats_##Name(args_length, args_object, isolate); \
« no previous file with comments | « no previous file | src/builtins/builtins-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698