Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2164573003: [turbofan] Introduce a TransitionElementsKind simplified operator. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a TransitionElementsKind simplified operator. Instead of wriring the elements kind transitions into the control flow early on, we do instead put this marker into the effect chain, so that the elements transitions are visible to the LoadElimination and can thus be optimized properly there. This CL itself doesn't add any of those optimizations, but just adds the foundations to make them possible later. R=jarin@chromium.org BUG=v8:4930, v8:5141 Committed: https://crrev.com/908cd09f3a181628d1e76b96995e424f0bb18201 Cr-Commit-Position: refs/heads/master@{#37869}

Patch Set 1 #

Patch Set 2 : Remove unrelated changes. #

Patch Set 3 : Fix the runtime fallback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -81 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 2 chunks +62 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 7 chunks +34 lines, -74 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 2 chunks +30 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/elements.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/elements.cc View 1 2 3 chunks +48 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-19 11:13:01 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the first step to finally optimize away the elements transitions. Please take ...
4 years, 5 months ago (2016-07-19 11:13:47 UTC) #4
Jarin
lgtm, thanks!
4 years, 5 months ago (2016-07-19 11:26:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164573003/20001
4 years, 5 months ago (2016-07-19 11:26:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5259) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-19 11:42:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164573003/40001
4 years, 5 months ago (2016-07-19 13:06:36 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 13:38:19 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 13:41:14 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/908cd09f3a181628d1e76b96995e424f0bb18201
Cr-Commit-Position: refs/heads/master@{#37869}

Powered by Google App Engine
This is Rietveld 408576698