Allow callable JS objects. dartbug.com/25321

Seems like this is all that is required to support callable JS objects. dartbug.com/25321

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/bbb0c3f7275295c79e639808f5777aedc6374f5a

[Jacob, 2016-07-20 00:53:56]

jacobr@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-07-20 18:21:27]

This 'works' because code is placed on Interceptor instead of JavaScriptObject.

If we make JavaScriptFunction and JavaScriptObject have a common base class and
put the code there then it would be OK.

[sra1, 2016-07-20 18:31:14]

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
File tests/html/js_typed_interop_callable_object_test.dart (right):

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
tests/html/js_typed_interop_callable_object_test.dart:33: external num call(num
a, num b);
Document somewhere that if a @JS class implements `call`, the underlying
representation must be a JavaScript callable (i.e. function).

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
tests/html/js_typed_interop_callable_object_test.dart:53: });
Add another test just like this, but with the dynamic case.

   var obj = confuse(callableObject);

[Jacob, 2016-07-20 19:52:24]

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
File tests/html/js_typed_interop_callable_object_test.dart (right):

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
tests/html/js_typed_interop_callable_object_test.dart:33: external num call(num
a, num b);
On 2016/07/20 18:31:14, sra1 wrote:
> Document somewhere that if a @JS class implements `call`, the underlying
> representation must be a JavaScript callable (i.e. function).

Acknowledged.

[Jacob, 2016-07-20 19:53:52]

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
File tests/html/js_typed_interop_callable_object_test.dart (right):

https://codereview.chromium.org/2164483004/diff/1/tests/html/js_typed_interop...
tests/html/js_typed_interop_callable_object_test.dart:53: });
On 2016/07/20 18:31:14, sra1 wrote:
> Add another test just like this, but with the dynamic case.
> 
>    var obj = confuse(callableObject);
> 

Done.

[sra1, 2016-07-20 20:11:26]

lgtm

[Jacob, 2016-07-20 20:16:40]

Description was changed from

==========
Seems like this is all that is required to support callable JS objects.
dartbug.com/25321

BUG=
==========

to

==========
Seems like this is all that is required to support callable JS objects.
dartbug.com/25321

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bbb0c3f7275295c79e639808f5777aedc6374f5a
==========

[Jacob, 2016-07-20 20:16:42]

Committed patchset #2 (id:20001) manually as
bbb0c3f7275295c79e639808f5777aedc6374f5a (presubmit successful).

[Bill Hesse, 2016-07-22 16:41:20]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-07-22 16:41:20]

This also affects issue https://github.com/dart-lang/sdk/issues/14813 and
changes the error on the test https://github.com/dart-lang/sdk/issues/14813 from
a CompileError to a RuntimeError.

I will update the status file for this.