pkg/compiler/lib/src/js_backend/backend.dart - Issue 2164483004: Allow callable JS objects. dartbug.com/25321

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2164483004: Allow callable JS objects. dartbug.com/25321 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Seems like this is all that is required to support callable JS objects. dartbug.com/25321 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart

index ebac46ba63cf0493ad0056769ced1aa2f54c5466..4bf0d1e2342c145a1108f018643470ee5352eac0 100644

--- a/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/pkg/compiler/lib/src/js_backend/backend.dart

@@ -945,8 +945,6 @@ class JavaScriptBackend extends Backend {

cls.ensureResolved(resolution);

cls.forEachMember((ClassElement classElement, Element member) {

if (member.name == Identifiers.call) {

- reporter.reportErrorMessage(

- member, MessageKind.CALL_NOT_SUPPORTED_ON_NATIVE_CLASS);

return;

}

if (member.isSynthesized) return;