Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: components/cronet/ios/BUILD.gn

Issue 2164393002: Add Info.plist support to ios_framework_bundle template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bundle-deps
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/BUILD.gn
diff --git a/components/cronet/ios/BUILD.gn b/components/cronet/ios/BUILD.gn
index 01c445b8e9a1897535d5f35c019e0f2e8f3a2729..38dfb99f79771606c85ce729862dbebcf1c2d239 100644
--- a/components/cronet/ios/BUILD.gn
+++ b/components/cronet/ios/BUILD.gn
@@ -61,29 +61,9 @@ tweak_info_plist("tweak_cronet_plist") {
args = []
}
-# Compile plist into |output_name|.
-ios_info_plist("compile_cronet_plist") {
- executable_name = "Cronet"
- output_name = "$target_gen_dir/Info.plist"
- info_plist_target = ":tweak_cronet_plist"
-}
-
-# Bundle plist into Cronet.Framework.
-bundle_data("cronet_info_plist") {
- public_deps = [
- ":compile_cronet_plist",
- ]
-
- sources = [
- "$target_gen_dir/Info.plist",
- ]
- outputs = [
- "{{bundle_root_dir}}/Info.plist",
- ]
-}
-
ios_framework_bundle("cronet_framework") {
output_name = "Cronet"
+ info_plist_target = ":tweak_cronet_plist"
deps = [
":cronet_sources",
@@ -91,8 +71,6 @@ ios_framework_bundle("cronet_framework") {
"//net:net",
]
- bundle_deps = [ ":cronet_info_plist" ]
-
libs = [ "UIKit.Framework" ]
public_headers = [

Powered by Google App Engine
This is Rietveld 408576698