Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: build/config/ios/rules.gni

Issue 2164393002: Add Info.plist support to ios_framework_bundle template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bundle-deps
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/ios/BUILD.gn » ('j') | ios/third_party/earl_grey/Info.plist » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index f423182a7ff65240650efa24632aec7272d5a1ae..144916ca03e3a764ce7221c82fb198d8bde2d4f0 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -793,6 +793,33 @@ template("ios_framework_bundle") {
}
}
+ if (!_is_fat_build || _is_fat_build_main_target) {
+ _info_plist_target = _target_name + "_info_plist"
+ _info_plist_bundle = _target_name + "_info_plist_bundle"
+ ios_info_plist(_info_plist_target) {
+ visibility = [ ":$_info_plist_bundle" ]
+ executable_name = _output_name
+ forward_variables_from(invoker,
+ [
+ "extra_substitutions",
+ "info_plist",
+ "info_plist_target",
+ ])
+ }
+
+ bundle_data(_info_plist_bundle) {
+ visibility = [ ":$_framework_target" ]
+ forward_variables_from(invoker, [ "testonly" ])
+ sources = get_target_outputs(":$_info_plist_target")
+ outputs = [
+ "{{bundle_root_dir}}/Info.plist",
+ ]
+ public_deps = [
+ ":$_info_plist_target",
+ ]
+ }
+ }
+
framework_bundle(_framework_target) {
forward_variables_from(invoker,
"*",
@@ -803,6 +830,13 @@ template("ios_framework_bundle") {
])
output_name = _output_name
+ if (!_is_fat_build || _is_fat_build_main_target) {
+ if (!defined(bundle_deps)) {
+ bundle_deps = []
+ }
+ bundle_deps += [ ":$_info_plist_bundle" ]
+ }
+
if (_has_public_headers) {
if (!defined(public_configs)) {
public_configs = []
« no previous file with comments | « no previous file | components/cronet/ios/BUILD.gn » ('j') | ios/third_party/earl_grey/Info.plist » ('J')

Powered by Google App Engine
This is Rietveld 408576698