Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 216433002: drive: Make FileResource copyable (Closed)

Created:
6 years, 8 months ago by hashimoto
Modified:
6 years, 8 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

drive: Make FileResource copyable To implement FakeDriveService without GData WAPI classes. BUG=334544 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260182

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -80 lines) Patch
M chrome/browser/drive/drive_api_util.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/drive/drive_api_util_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 6 chunks +31 lines, -35 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_parser.h View 7 chunks +5 lines, -15 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 2 chunks +26 lines, -2 lines 0 comments Download
M google_apis/drive/drive_api_parser_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
hashimoto
I think using std::vector instead of ScopedVector to store ParentResource in FIleResource is OK. Additional ...
6 years, 8 months ago (2014-03-28 07:51:57 UTC) #1
hashimoto
On 2014/03/28 07:51:57, hashimoto wrote: > I think using std::vector instead of ScopedVector to store ...
6 years, 8 months ago (2014-03-28 07:52:18 UTC) #2
kinaba
lgtm
6 years, 8 months ago (2014-03-28 08:31:44 UTC) #3
tzik
Change itself LGTM. Are you going to convert other classes to copyable classes?
6 years, 8 months ago (2014-03-28 08:46:35 UTC) #4
hashimoto
On 2014/03/28 08:46:35, tzik wrote: > Change itself LGTM. > Are you going to convert ...
6 years, 8 months ago (2014-03-28 09:05:09 UTC) #5
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-03-28 09:05:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/216433002/50001
6 years, 8 months ago (2014-03-28 09:05:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 14:02:18 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137258
6 years, 8 months ago (2014-03-28 14:02:18 UTC) #9
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-03-28 15:02:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/216433002/50001
6 years, 8 months ago (2014-03-28 15:05:32 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 17:21:01 UTC) #12
Message was sent while issue was closed.
Change committed as 260182

Powered by Google App Engine
This is Rietveld 408576698