Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1910)

Unified Diff: chrome/browser/drive/drive_api_util.cc

Issue 216433002: drive: Make FileResource copyable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/drive/drive_api_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/drive/drive_api_util.cc
diff --git a/chrome/browser/drive/drive_api_util.cc b/chrome/browser/drive/drive_api_util.cc
index ecadaad97dc4ae35902fcbee48a08e217a5891fb..cf8076694abd9d763d2f0561dc94f41f46c08603 100644
--- a/chrome/browser/drive/drive_api_util.cc
+++ b/chrome/browser/drive/drive_api_util.cc
@@ -343,21 +343,20 @@ scoped_ptr<google_apis::FileResource> ConvertResourceEntryToFileResource(
image_media_metadata->set_height(entry.image_height());
image_media_metadata->set_rotation(entry.image_rotation());
- ScopedVector<google_apis::ParentReference> parents;
+ std::vector<google_apis::ParentReference>* parents = file->mutable_parents();
for (size_t i = 0; i < entry.links().size(); ++i) {
using google_apis::Link;
const Link& link = *entry.links()[i];
switch (link.type()) {
case Link::LINK_PARENT: {
- scoped_ptr<google_apis::ParentReference> parent(
- new google_apis::ParentReference);
- parent->set_parent_link(link.href());
+ google_apis::ParentReference parent;
+ parent.set_parent_link(link.href());
std::string file_id =
drive::util::ExtractResourceIdFromUrl(link.href());
- parent->set_file_id(file_id);
- parent->set_is_root(file_id == kWapiRootDirectoryResourceId);
- parents.push_back(parent.release());
+ parent.set_file_id(file_id);
+ parent.set_is_root(file_id == kWapiRootDirectoryResourceId);
+ parents->push_back(parent);
break;
}
case Link::LINK_ALTERNATE:
@@ -367,7 +366,6 @@ scoped_ptr<google_apis::FileResource> ConvertResourceEntryToFileResource(
break;
}
}
- file->set_parents(parents.Pass());
file->set_modified_date(entry.updated_time());
file->set_last_viewed_by_me_date(entry.last_viewed_time());
@@ -449,7 +447,7 @@ ConvertFileResourceToResourceEntry(
for (size_t i = 0; i < file_resource.parents().size(); ++i) {
google_apis::Link* link = new google_apis::Link;
link->set_type(google_apis::Link::LINK_PARENT);
- link->set_href(file_resource.parents()[i]->parent_link());
+ link->set_href(file_resource.parents()[i].parent_link());
links.push_back(link);
}
if (!file_resource.alternate_link().is_empty()) {
« no previous file with comments | « no previous file | chrome/browser/drive/drive_api_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698