Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2164283002: Drop support for libjpeg-turbo < 1.2 in SkJpegCodec (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Drop support for libjpeg-turbo < 1.2 in SkJpegCodec BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164283002 Committed: https://skia.googlesource.com/skia/+/f25bff95db388554027c78df709f78f8278fffed

Patch Set 1 : Check for > 1.2 #

Patch Set 2 : Check for > 1.3 #

Patch Set 3 : Remove ifdefs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M src/codec/SkJpegCodec.cpp View 1 2 4 chunks +6 lines, -15 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
msarett
Three notable clients have all updated libjpeg-turbo. My goal was to clean things up a ...
4 years, 5 months ago (2016-07-21 15:26:53 UTC) #4
mtklein
lgtm
4 years, 5 months ago (2016-07-21 18:32:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164283002/40001
4 years, 5 months ago (2016-07-21 18:32:52 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:00:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f25bff95db388554027c78df709f78f8278fffed

Powered by Google App Engine
This is Rietveld 408576698