Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: remoting/protocol/webrtc_transport.cc

Issue 2164163002: Simplify data channel creation logic in WebRTC-based protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/webrtc_transport.h ('k') | remoting/protocol/webrtc_transport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_transport.cc
diff --git a/remoting/protocol/webrtc_transport.cc b/remoting/protocol/webrtc_transport.cc
index 1f96f1dccaf9c91f15383ac58a05b1e64bb30a92..ac3b6b32398af1d83681118b97f228692b22d623 100644
--- a/remoting/protocol/webrtc_transport.cc
+++ b/remoting/protocol/webrtc_transport.cc
@@ -152,6 +152,11 @@ WebrtcTransport::WebrtcTransport(
WebrtcTransport::~WebrtcTransport() {}
+std::unique_ptr<MessagePipe> WebrtcTransport::CreateOutgoingChannel(
+ const std::string& name) {
+ return data_stream_adapter_->CreateOutgoingChannel(name);
+}
+
void WebrtcTransport::Start(
Authenticator* authenticator,
SendTransportInfoCallback send_transport_info_callback) {
@@ -192,9 +197,7 @@ void WebrtcTransport::Start(
peer_connection_ = peer_connection_factory_->CreatePeerConnection(
rtc_config, &constraints, std::move(port_allocator), nullptr, this);
- data_stream_adapter_.reset(new WebrtcDataStreamAdapter(
- base::Bind(&WebrtcTransport::Close, base::Unretained(this))));
- data_stream_adapter_->Initialize(peer_connection_);
+ data_stream_adapter_.reset(new WebrtcDataStreamAdapter(peer_connection_));
event_handler_->OnWebrtcTransportConnecting();
@@ -434,10 +437,9 @@ void WebrtcTransport::OnRemoveStream(
void WebrtcTransport::OnDataChannel(
rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel) {
DCHECK(thread_checker_.CalledOnValidThread());
- data_stream_adapter_->WrapIncomingDataChannel(
- data_channel,
- base::Bind(&EventHandler::OnWebrtcTransportIncomingDataChannel,
- base::Unretained(event_handler_), data_channel->label()));
+ event_handler_->OnWebrtcTransportIncomingDataChannel(
+ data_channel->label(),
+ data_stream_adapter_->WrapIncomingDataChannel(data_channel));
}
void WebrtcTransport::OnRenegotiationNeeded() {
« no previous file with comments | « remoting/protocol/webrtc_transport.h ('k') | remoting/protocol/webrtc_transport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698