chrome/browser/ui/startup/startup_browser_creator.h - Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator.h

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Win build issue Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.h » ('j') | chrome/browser/ui/startup/startup_browser_creator_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator.h

diff --git a/chrome/browser/ui/startup/startup_browser_creator.h b/chrome/browser/ui/startup/startup_browser_creator.h

index 1081c16ef8baf44e76f6044340ba7ada871918ed..53ac4636786c521339263b45b299449ff19c7fe1 100644

--- a/chrome/browser/ui/startup/startup_browser_creator.h

+++ b/chrome/browser/ui/startup/startup_browser_creator.h

@@ -108,6 +108,8 @@ class StartupBrowserCreator {

friend class CloudPrintProxyPolicyTest;

friend class CloudPrintProxyPolicyStartupTest;

friend class StartupBrowserCreatorImpl;

+ // TODO(crbug/642442): Remove this when first_run_tabs gets refactored.

Peter Kasting 2016/09/29 07:23:33 Tiny nit: "crbug/" only works on corp. I tend to

+ friend class StartupTabProviderImpl;

FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,

ReadingWasRestartedAfterNormalStart);

FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,