Refactoring startup logic for upcoming FRE changes (non-Win 10).

chrome/browser/ui/startup/startup_browser_creator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 #define CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 90 matching lines @@
 
   // For faking that no profiles have been launched yet.
   static void ClearLaunchedProfilesForTesting();
 
   static void RegisterLocalStatePrefs(PrefRegistrySimple* registry);
 
  private:
   friend class CloudPrintProxyPolicyTest;
   friend class CloudPrintProxyPolicyStartupTest;
   friend class StartupBrowserCreatorImpl;
+  // TODO(crbug/642442): Remove this when first_run_tabs gets refactored.

[Peter Kasting, 2016/09/29 07:23:33]

Tiny nit: "crbug/" only works on corp.  I tend to prefer e.g. "crbug.com/#" (or
just "bug #", or a username)

+  friend class StartupTabProviderImpl;
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterNormalStart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterRestart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, UpdateWithTwoProfiles);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, LastUsedProfileActivated);
 
   bool ProcessCmdLineImpl(const base::CommandLine& command_line,
                           const base::FilePath& cur_dir,
                           bool process_startup,
@@ skipping 69 matching lines @@
                            const base::CommandLine& command_line);
 
 // Returns the profile that should be loaded on process startup when
 // GetStartupProfile() returns null. As with GetStartupProfile(), returning the
 // guest profile means the caller should open the user manager. This may return
 // null if neither any profile nor the user manager can be opened.
 Profile* GetFallbackStartupProfile();
 #endif  // !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
 
 #endif  // CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_