chrome/browser/ui/startup/startup_tab.cc - Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_tab.cc

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding missing constructor Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/startup/startup_tab.h ('K') | « chrome/browser/ui/startup/startup_tab.h ('k') | chrome/browser/ui/startup/startup_tab_provider.h » ('j') | chrome/browser/ui/startup/startup_tab_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_tab.cc

diff --git a/chrome/browser/ui/startup/startup_tab.cc b/chrome/browser/ui/startup/startup_tab.cc

index cda2d9453571489bab47236d48408862d6dfebdb..968bd433f425737691a5fbdb4e049e9849879ffc 100644

--- a/chrome/browser/ui/startup/startup_tab.cc

+++ b/chrome/browser/ui/startup/startup_tab.cc

@@ -8,5 +8,8 @@ StartupTab::StartupTab()

: is_pinned(true) {

}

+StartupTab::StartupTab(GURL url_, bool is_pinned_)

+ : url(url_), is_pinned(is_pinned_) {}

grt (UTC plus 2) 2016/09/09 11:40:30 i was going to suggest using std::move to get the

StartupTab::~StartupTab() {

}