chrome/browser/ui/startup/startup_tab.cc - Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/startup/startup_tab.cc

Issue 2164033002: Refactoring startup logic for upcoming FRE changes (non-Win 10). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding missing constructor Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/startup/startup_tab.h ('K') | « chrome/browser/ui/startup/startup_tab.h ('k') | chrome/browser/ui/startup/startup_tab_provider.h » ('j') | chrome/browser/ui/startup/startup_tab_provider.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/startup/startup_tab.h"	5 #include "chrome/browser/ui/startup/startup_tab.h"

6	6

7 StartupTab::StartupTab()	7 StartupTab::StartupTab()

8 : is_pinned(true) {	8 : is_pinned(true) {

9 }	9 }

10	10

	11 StartupTab::StartupTab(GURL url_, bool is_pinned_)

	12 : url(url_), is_pinned(is_pinned_) {}
	grt (UTC plus 2) 2016/09/09 11:40:30 i was going to suggest using std::move to get the i was going to suggest using std::move to get the url into place, but it looks to me like GURL isn't currently movable. how about taking the url as constref?
	13

11 StartupTab::~StartupTab() {	14 StartupTab::~StartupTab() {

12 }	15 }

OLD	NEW