Move CompileString to Compiler

Move CompileString to Compiler

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/95708d14587b1d0755a2d041d460440b939e7d59
Cr-Commit-Position: refs/heads/master@{#37909}

[Yang, 2016-07-20 11:52:26]

yangguo@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Yang, 2016-07-20 11:52:27]

LGTM, but please wait for Michael to sign this off; compiler.cc is his precious
:)

[Michael Starzinger, 2016-07-20 12:03:36]

General question: Would it be possible to make Runtime_ResolvePossiblyDirectEval
also use the new compiler API method?

https://codereview.chromium.org/2163933002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2163933002/diff/1/src/compiler.cc#newcode1783
src/compiler.cc:1783: MaybeHandle<JSFunction>
Compiler::CompileString(Handle<Context> context,
Likewise, please move this to after GetFunctionFromEval.

https://codereview.chromium.org/2163933002/diff/1/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/2163933002/diff/1/src/compiler.h#newcode96
src/compiler.h:96: MUST_USE_RESULT static MaybeHandle<JSFunction> CompileString(
Can we call this "GetFunctomFromString" instead. The family of CompileFoo
methods is intended to compile existing functions and mutate them to have
appropriate machine code or byte code. Whereas this family of methods actually
instantiates new functions.

Also let's move this up one function, to after GetFunctionFromEval, as it is
closely related to that.

Also, same comment as for GetFunctionFromEval applies to this.

[Michael Starzinger, 2016-07-20 12:05:13]

https://codereview.chromium.org/2163933002/diff/1/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/2163933002/diff/1/src/compiler.h#newcode96
src/compiler.h:96: MUST_USE_RESULT static MaybeHandle<JSFunction> CompileString(
On 2016/07/20 12:03:35, Michael Starzinger wrote:
> Can we call this "GetFunctomFromString" instead. The family of CompileFoo
> methods is intended to compile existing functions and mutate them to have
> appropriate machine code or byte code. Whereas this family of methods actually
> instantiates new functions.
> 
> Also let's move this up one function, to after GetFunctionFromEval, as it is
> closely related to that.
> 
> Also, same comment as for GetFunctionFromEval applies to this.

s/GetFunctomFromString/GetFunctionFromString/ of course. :)

[jgruber, 2016-07-20 12:42:11]

Re: Runtime_ResolvePossiblyDirectEval, not in its current form, since it has,
e.g., an eval_position which GetFunctionFromString simply sets to
kNoSourcePosition. We could take a look at this in a follow-up CL though.

https://codereview.chromium.org/2163933002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2163933002/diff/1/src/compiler.cc#newcode1783
src/compiler.cc:1783: MaybeHandle<JSFunction>
Compiler::CompileString(Handle<Context> context,
On 2016/07/20 12:03:35, Michael Starzinger wrote:
> Likewise, please move this to after GetFunctionFromEval.

Done.

https://codereview.chromium.org/2163933002/diff/1/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/2163933002/diff/1/src/compiler.h#newcode96
src/compiler.h:96: MUST_USE_RESULT static MaybeHandle<JSFunction> CompileString(
On 2016/07/20 12:03:35, Michael Starzinger wrote:
> Can we call this "GetFunctomFromString" instead. The family of CompileFoo
> methods is intended to compile existing functions and mutate them to have
> appropriate machine code or byte code. Whereas this family of methods actually
> instantiates new functions.
> 
> Also let's move this up one function, to after GetFunctionFromEval, as it is
> closely related to that.
> 
> Also, same comment as for GetFunctionFromEval applies to this.

Done.

[Michael Starzinger, 2016-07-20 12:58:47]

LGTM. Thanks!

[jgruber, 2016-07-20 13:01:09]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-07-20 13:01:09]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2163933002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-07-20 13:01:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 13:29:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 13:34:09]

Description was changed from

==========
Move CompileString to Compiler

R=yangguo@chromium.org
BUG=
==========

to

==========
Move CompileString to Compiler

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/95708d14587b1d0755a2d041d460440b939e7d59
Cr-Commit-Position: refs/heads/master@{#37909}
==========

[commit-bot: I haz the power, 2016-07-20 13:34:10]

Patchset 2 (id:??) landed as
https://crrev.com/95708d14587b1d0755a2d041d460440b939e7d59
Cr-Commit-Position: refs/heads/master@{#37909}