Move CompileString to Compiler

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include "src/allocation.h"
 #include "src/ast/ast.h"
 #include "src/bailout-reason.h"
@@ skipping 75 matching lines @@
 
   // Create a shared function info object for a String source within a context.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForScript(
       Handle<String> source, Handle<Object> script_name, int line_offset,
       int column_offset, ScriptOriginOptions resource_options,
       Handle<Object> source_map_url, Handle<Context> context,
       v8::Extension* extension, ScriptData** cached_data,
       ScriptCompiler::CompileOptions compile_options,
       NativesFlag is_natives_code, bool is_module);
 
+  MUST_USE_RESULT static MaybeHandle<JSFunction> CompileString(

[Michael Starzinger, 2016/07/20 12:03:35]

Can we call this "GetFunctomFromString" instead. The family of CompileFoo
methods is intended to compile existing functions and mutate them to have
appropriate machine code or byte code. Whereas this family of methods actually
instantiates new functions.

Also let's move this up one function, to after GetFunctionFromEval, as it is
closely related to that.

Also, same comment as for GetFunctionFromEval applies to this.

[Michael Starzinger, 2016/07/20 12:05:12]

s/GetFunctomFromString/GetFunctionFromString/ of course. :)

[jgruber, 2016/07/20 12:42:11]

Done.

+      Handle<Context> context, Handle<String> source,
+      ParseRestriction restriction);
+
   // Create a shared function info object for a Script that has already been
   // parsed while the script was being loaded from a streamed source.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForStreamedScript(
       Handle<Script> script, ParseInfo* info, int source_length);
 
   // Create a shared function info object (the code may be lazily compiled).
   static Handle<SharedFunctionInfo> GetSharedFunctionInfo(
       FunctionLiteral* node, Handle<Script> script, CompilationInfo* outer);
 
   // Create a shared function info object for a native function literal.
@@ skipping 466 matching lines @@
   MUST_USE_RESULT Status SetLastStatus(Status status) {
     last_status_ = status;
     return last_status_;
   }
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_H_