Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2163923002: Revert "Don't define |r_debug| and |link_map| on Android releases 21 and later" (Closed)

Created:
4 years, 5 months ago by rmcilroy
Modified:
4 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Don't define |r_debug| and |link_map| on Android releases 21 and later" This reverts commit 0fc10739232ac803f7304d01522db6051c7454ff. Reason: breaks 64bit Android architectures. BUG=629088 R=primiano@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/b5200a97b7e10b808665b2059f6b89edacd9919f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M src/common/android/include/link.h View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmcilroy
Primiano, could you take a look please?
4 years, 5 months ago (2016-07-20 10:20:40 UTC) #3
Primiano Tucci (use gerrit)
lgtm
4 years, 5 months ago (2016-07-20 10:26:28 UTC) #4
rmcilroy
4 years, 5 months ago (2016-07-20 10:27:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5200a97b7e10b808665b2059f6b89edacd9919f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698