chrome/browser/resources/ntp4/new_tab.js - Issue 2163893003: Start sending auxclick instead of click for non-primary buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 2163893003: Start sending auxclick instead of click for non-primary buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing auxclick polyfill for remote devtools Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/ntp4/nav_dot.js ('K') | « chrome/browser/resources/ntp4/nav_dot.js ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/ntp4/new_tab.js

diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js

index 43e25f756290ee3f8dd76be31e0b2c6042e8bdba..821ab156cd779d54f7466c95de0226069addbf21 100644

--- a/chrome/browser/resources/ntp4/new_tab.js

+++ b/chrome/browser/resources/ntp4/new_tab.js

@@ -104,6 +104,8 @@ cr.define('ntp', function() {

var webStoreLink = loadTimeData.getString('webStoreLink');

var url = appendParam(webStoreLink, 'utm_source', 'chrome-ntp-launcher');

$('chrome-web-store-link').href = url;

+ $('chrome-web-store-link').addEventListener('auxclick',

+ onChromeWebStoreButtonClick);

Dan Beam 2016/08/10 22:35:27 you're thinking of this code

$('chrome-web-store-link').addEventListener('click',

onChromeWebStoreButtonClick);

}

@@ -155,7 +157,7 @@ cr.define('ntp', function() {

/**

* Launches the chrome web store app with the chrome-ntp-launcher

* source.

- * @param {Event} e The click event.

+ * @param {Event} e The click/auxclick event.

function onChromeWebStoreButtonClick(e) {

chrome.send('recordAppLaunchByURL',