Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6843)

Unified Diff: chrome/browser/resources/ntp4/nav_dot.js

Issue 2163893003: Start sending auxclick instead of click for non-primary buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing auxclick polyfill for remote devtools Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/nav_dot.js
diff --git a/chrome/browser/resources/ntp4/nav_dot.js b/chrome/browser/resources/ntp4/nav_dot.js
index 98f02785724ae9e6475319780d491bfc5e28570b..6287f51ece6f0e27d3d90f3a44ea5498d59307c8 100644
--- a/chrome/browser/resources/ntp4/nav_dot.js
+++ b/chrome/browser/resources/ntp4/nav_dot.js
@@ -55,6 +55,7 @@ cr.define('ntp', function() {
this.addEventListener('keydown', this.onKeyDown_);
this.addEventListener('click', this.onClick_);
+ this.addEventListener('auxclick', this.onClick_);
Dan Beam 2016/08/09 02:04:34 did people file bugs on your about not switching t
Navid Zolghadr 2016/08/09 13:34:46 There was no bug filed for this. This was one of t
Dan Beam 2016/08/09 16:22:54 I think it's fine just to ignore auxiliary clicks
Navid Zolghadr 2016/08/10 14:32:09 If I recall correctly there is this little functio
Dan Beam 2016/08/10 22:35:26 see other comment
Navid Zolghadr 2016/08/11 16:11:03 Removed it. I guess if any bug comes up later we c
this.addEventListener('dblclick', this.onDoubleClick_);
this.dragWrapper_ = new cr.ui.DragWrapper(this, this);
this.addEventListener('webkitTransitionEnd', this.onTransitionEnd_);

Powered by Google App Engine
This is Rietveld 408576698