Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2163873003: Ensure invalidation in LayoutBlockChildNode::removeChildNodes() without notifyLayoutObject (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Ensure invalidation in LayoutBlockChildNode::removeChildNodes() without notifyLayoutObject Some callers of LayoutBlockChildNode::removeChildNodes() passes notifyLayoutObject=false and we missed invalidation of the painting layer and the object. The test case is converted from a cluster-fuzz test case. BUG=628146 Review-Url: https://codereview.chromium.org/2160723006 Cr-Commit-Position: refs/heads/master@{#406436} Committed: https://chromium.googlesource.com/chromium/src/+/f3d584d7a3188951128b5daa2b1d9f15e5306b52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/remove-anonymous-block-crash.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/remove-anonymous-block-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Xianzhu
4 years, 5 months ago (2016-07-21 06:01:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3d584d7a3188951128b5daa2b1d9f15e5306b52.

Powered by Google App Engine
This is Rietveld 408576698