Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2160723006: Ensure invalidation in LayoutBlockChildNode::removeChildNodes() without notifyLayoutObject (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure invalidation in LayoutBlockChildNode::removeChildNodes() without notifyLayoutObject Some callers of LayoutBlockChildNode::removeChildNodes() passes notifyLayoutObject=false and we missed invalidation of the painting layer and the object. The test case is converted from a cluster-fuzz test case. BUG=628146 Committed: https://crrev.com/f19f54dd68934165d539d3d1aaeb90a24f7e0049 Cr-Commit-Position: refs/heads/master@{#406436}

Patch Set 1 #

Patch Set 2 : NeedsRebaseline #

Patch Set 3 : Adjust comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/remove-anonymous-block-crash.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/remove-anonymous-block-crash-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xianzhu
4 years, 5 months ago (2016-07-19 21:20:40 UTC) #6
chrishtr
lgtm
4 years, 5 months ago (2016-07-19 22:00:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160723006/40001
4 years, 5 months ago (2016-07-19 22:02:43 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 01:07:51 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 01:11:43 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f19f54dd68934165d539d3d1aaeb90a24f7e0049
Cr-Commit-Position: refs/heads/master@{#406436}

Powered by Google App Engine
This is Rietveld 408576698