Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2163833004: exclude unused functions when mac uses freetype (for pdf) (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make onGetAdvancedTypefaceMetrics compile on mac instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caryclark
4 years, 5 months ago (2016-07-20 15:14:24 UTC) #2
caryclark
Ben, I verified that with this patch skia-PDFium builds on Mac in debug and release
4 years, 5 months ago (2016-07-20 16:26:43 UTC) #3
bungeman-skia
lgtm
4 years, 5 months ago (2016-07-20 19:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163833004/20001
4 years, 5 months ago (2016-07-20 19:58:44 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 20:15:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7d46f4af7dc759002537a172af121f2bfe200981

Powered by Google App Engine
This is Rietveld 408576698