src/ports/SkFontHost_FreeType.cpp - Issue 2163833004: exclude unused functions when mac uses freetype (for pdf)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_FreeType.cpp

Issue 2163833004: exclude unused functions when mac uses freetype (for pdf) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: make onGetAdvancedTypefaceMetrics compile on mac instead Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_FreeType.cpp

diff --git a/src/ports/SkFontHost_FreeType.cpp b/src/ports/SkFontHost_FreeType.cpp

index d0f86d99a70528f9503ad8ff3b6b23dd6b180a51..45e4eaead8616a4d34c4db6997fdf8cf29804af8 100644

--- a/src/ports/SkFontHost_FreeType.cpp

+++ b/src/ports/SkFontHost_FreeType.cpp

@@ -456,9 +456,6 @@ SkAdvancedTypefaceMetrics* SkTypeface_FreeType::onGetAdvancedTypefaceMetrics(

PerGlyphInfo perGlyphInfo,

const uint32_t* glyphIDs,

uint32_t glyphIDsCount) const {

-#if defined(SK_BUILD_FOR_MAC)

- return nullptr;

-#else

AutoFTAccess fta(this);

FT_Face face = fta.face();

if (!face) {

@@ -654,7 +651,6 @@ SkAdvancedTypefaceMetrics* SkTypeface_FreeType::onGetAdvancedTypefaceMetrics(

}

return info;

-#endif

}

///////////////////////////////////////////////////////////////////////////

« no previous file with comments | « no previous file | no next file » | no next file with comments »