cc : Use effect id to decide if surface contents scale should be applied

cc : Use effect id to decide if surface contents scale should be applied

We don't apply surface contents scale for root. We
currently check the transform id to determine if we are at
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/94332903cf65b0dd8bd41fd63586a411f6df01c1
Cr-Commit-Position: refs/heads/master@{#407547}

[jaydasika, 2016-07-20 18:13:28]

Description was changed from

==========
cc : Use effect id to decide if surface contents scale should be applied

Instead of transform id.

BUG=622372
==========

to

==========
cc : Use effect id to decide if surface contents scale should be applied

Instead of transform id.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-07-20 18:19:27]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-07-20 18:19:27]

Right now, we have to check both 0 and 1, if we are using effect tree. After
crbug.com/620322 is fixed, we should be checking just one id.

[jaydasika, 2016-07-20 18:20:14]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 18:20:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-07-20 19:08:19]

Removed checking for id 0.

[jaydasika, 2016-07-20 19:08:42]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:09:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:12:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ajuma, 2016-07-20 20:23:58]

lgtm, but please write a more descriptive description :)

[jaydasika, 2016-07-20 20:26:15]

Description was changed from

==========
cc : Use effect id to decide if surface contents scale should be applied

Instead of transform id.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc : Use effect id to decide if surface contents scale should be applied

We don't apply surface contents scale for root. We 
currently check the transform id to determine if we are at 
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-07-22 23:13:38]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 23:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 23:16:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 23:16:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[jaydasika, 2016-07-22 23:25:48]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 23:26:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-07-22 23:30:10]

I have added code to handle PAC not setting effect ids on clip nodes.
This CL would make progress in moving towards removing the assumption that
render surfaces create transform nodes (by making surface contents scale
independent of transform tree), but with an extra hack for handling PAC.
So, I am not sure if we should land this. I don't feel strongly either way. WDYT
?

[jaydasika, 2016-07-22 23:39:00]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 23:39:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 00:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 00:30:57]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-07-25 15:23:05]

On 2016/07/22 23:30:10, jaydasika wrote:
> I have added code to handle PAC not setting effect ids on clip nodes.
> This CL would make progress in moving towards removing the assumption that
> render surfaces create transform nodes (by making surface contents scale
> independent of transform tree), but with an extra hack for handling PAC.
> So, I am not sure if we should land this. I don't feel strongly either way.
WDYT
> ?

This CL does move things in the right direction overall. I think there's a small
risk that the workaround to handle PAC will allow bugs to creep in, but on the
whole I think this is worth landing.

[jaydasika, 2016-07-25 17:45:56]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-07-25 17:45:57]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2163823003/#ps140001
(title: "fix_compile_error")

[commit-bot: I haz the power, 2016-07-25 17:46:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 19:41:12]

Description was changed from

==========
cc : Use effect id to decide if surface contents scale should be applied

We don't apply surface contents scale for root. We 
currently check the transform id to determine if we are at 
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc : Use effect id to decide if surface contents scale should be applied

We don't apply surface contents scale for root. We 
currently check the transform id to determine if we are at 
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-25 19:41:18]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-07-25 19:43:43]

Description was changed from

==========
cc : Use effect id to decide if surface contents scale should be applied

We don't apply surface contents scale for root. We 
currently check the transform id to determine if we are at 
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc : Use effect id to decide if surface contents scale should be applied

We don't apply surface contents scale for root. We
currently check the transform id to determine if we are at
root node. This CL replaces that with effect ids.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/94332903cf65b0dd8bd41fd63586a411f6df01c1
Cr-Commit-Position: refs/heads/master@{#407547}
==========

[commit-bot: I haz the power, 2016-07-25 19:43:45]

Patchset 8 (id:??) landed as
https://crrev.com/94332903cf65b0dd8bd41fd63586a411f6df01c1
Cr-Commit-Position: refs/heads/master@{#407547}