Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 2163803003: [chrome_elf] Removing blacklist finch for dynamic dll changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/win/chrome_elf_init_unittest.cc ('k') | chrome_elf/blacklist/blacklist.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 24f2ba07d2e15c71524d34fde25ff81425e2d42f..8f4a4dedd9d55627136845ebd88ccedd7a4f8c70 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -786,8 +786,17 @@ void RemoveBlacklistState() {
InstallUtil::DeleteRegistryKey(HKEY_CURRENT_USER,
blacklist::kRegistryBeaconPath,
0); // wow64_access
+// The following key is no longer used (https://crbug.com/631771).
+// This cleanup is being left in for a time though.
+#if defined(GOOGLE_CHROME_BUILD)
+ const wchar_t kRegistryFinchListPath[] =
+ L"SOFTWARE\\Google\\Chrome\\BLFinchList";
+#else
+ const wchar_t kRegistryFinchListPath[] =
+ L"SOFTWARE\\Chromium\\BLFinchList";
+#endif
InstallUtil::DeleteRegistryKey(HKEY_CURRENT_USER,
- blacklist::kRegistryFinchListPath,
+ kRegistryFinchListPath,
0); // wow64_access
}
« no previous file with comments | « chrome/browser/win/chrome_elf_init_unittest.cc ('k') | chrome_elf/blacklist/blacklist.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698