Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2148)

Unified Diff: chrome/browser/win/chrome_elf_init_unittest.cc

Issue 2163803003: [chrome_elf] Removing blacklist finch for dynamic dll changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/win/chrome_elf_init.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/chrome_elf_init_unittest.cc
diff --git a/chrome/browser/win/chrome_elf_init_unittest.cc b/chrome/browser/win/chrome_elf_init_unittest.cc
index 3c23e4929eddec321a6f11d190526afc9b021f44..295fbd763be4b1d1bd240b037399b112fc3a31a5 100644
--- a/chrome/browser/win/chrome_elf_init_unittest.cc
+++ b/chrome/browser/win/chrome_elf_init_unittest.cc
@@ -21,8 +21,6 @@
namespace {
-const char kBrowserBlacklistTrialEnabledGroupName[] = "Enabled";
-
class ChromeBlacklistTrialTest : public testing::Test {
protected:
ChromeBlacklistTrialTest() {}
@@ -156,45 +154,4 @@ TEST_F(ChromeBlacklistTrialTest, VersionChanged) {
ASSERT_EQ(static_cast<DWORD>(0), attempt_count);
}
-TEST_F(ChromeBlacklistTrialTest, AddFinchBlacklistToRegistry) {
- // Create the field trial with the blacklist enabled group.
- base::FieldTrialList field_trial_list(
- new metrics::SHA1EntropyProvider("test"));
-
- scoped_refptr<base::FieldTrial> trial(base::FieldTrialList::CreateFieldTrial(
- kBrowserBlacklistTrialName, kBrowserBlacklistTrialEnabledGroupName));
-
- // Set up the trial with the desired parameters.
- std::map<std::string, std::string> desired_params;
-
- desired_params[blacklist::kRegistryFinchListValueNameStr] =
- "TestDll1.dll,TestDll2.dll";
-
- variations::AssociateVariationParams(
- kBrowserBlacklistTrialName,
- kBrowserBlacklistTrialEnabledGroupName,
- desired_params);
-
- // This should add the dlls in those parameters to the registry.
- AddFinchBlacklistToRegistry();
-
- // Check that all the dll names in desired_params were added to the registry.
- std::vector<std::wstring> dlls;
-
- base::win::RegKey finch_blacklist_registry_key(
- HKEY_CURRENT_USER,
- blacklist::kRegistryFinchListPath,
- KEY_QUERY_VALUE | KEY_SET_VALUE);
-
- ASSERT_TRUE(finch_blacklist_registry_key.HasValue(
- blacklist::kRegistryFinchListValueName));
- ASSERT_EQ(ERROR_SUCCESS, finch_blacklist_registry_key.ReadValues(
- blacklist::kRegistryFinchListValueName, &dlls));
-
- ASSERT_EQ((size_t)2,
- /* Number of dll names passed in this test. */ dlls.size());
- EXPECT_STREQ(L"TestDll1.dll", dlls[0].c_str());
- EXPECT_STREQ(L"TestDll2.dll", dlls[1].c_str());
-}
-
} // namespace
« no previous file with comments | « chrome/browser/win/chrome_elf_init.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698