Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2163753003:
[Md Feedback] Add the rest of existing strings. (Closed)
|
Created:
4 years, 5 months ago by apacible Modified:
4 years, 5 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Md Feedback] Add the rest of existing strings.
This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow.
The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign.
No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog.
BUG=615535
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d
Cr-Commit-Position: refs/heads/master@{#407636}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Gate privacy note for official branded browsers. #
Messages
Total messages: 26 (18 generated)
Description was changed from ========== add the last strings / ui components to webui BUG= ========== to ========== add the last strings / ui components to webui BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== add the last strings / ui components to webui BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. The remaining missing strings (upload file) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. The remaining missing strings (upload file) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
apacible@chromium.org changed reviewers: + dbeam@chromium.org
PTAL, thanks!
https://codereview.chromium.org/2163753003/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2163753003/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:7779: + Your Chrome and operating system version will be submitted in addition this mentioned the product name, and therefore should be in {chromium,google_chrome}_strings.grd https://codereview.chromium.org/2163753003/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:7784: + accordance with our privacy policies.<ph name="BEGIN_BOLD"><strong> why are you using <ph> here? maybe this should be a separate <message>?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2163753003/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2163753003/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:7779: + Your Chrome and operating system version will be submitted in addition On 2016/07/19 22:13:58, Dan Beam wrote: > this mentioned the product name, and therefore should be in > {chromium,google_chrome}_strings.grd This string is only used in chrome branded builds. {chromium,google_chrome}_strings.grd appear to replace each other depending on the build branding. I was following the implementation for the current privacy note: https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=7717 Is there a better place than here and the aforementioned .grd files? https://codereview.chromium.org/2163753003/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:7784: + accordance with our privacy policies.<ph name="BEGIN_BOLD"><strong> On 2016/07/19 22:13:58, Dan Beam wrote: > why are you using <ph> here? maybe this should be a separate <message>? This follows the pattern for the other strings that have partial styling -- i.e. bold. There's some other examples in this file, e.g. IDS_CAPTIVE_PORTAL_PRIMARY_PARAGRAPH_WIRED.
i think you just found 2 very bad examples of things i don't care enough to find a better place for your string that mentions "Chrome" (i.e. Google Chrome), so let's hope they don't make their way to Chromium and make us look bad and I was too lazy to talk to somebody that works on the translation console to ask if placeholders are somehow useful around HTML. but I really don't imagine they are. lgtm
On 2016/07/22 01:28:45, Dan Beam wrote: > i think you just found 2 very bad examples of things > > i don't care enough to find a better place for your string that mentions > "Chrome" (i.e. Google Chrome), so let's hope they don't make their way to > Chromium and make us look bad > > and I was too lazy to talk to somebody that works on the translation console to > ask if placeholders are somehow useful around HTML. but I really don't imagine > they are. > > lgtm Thanks, I'll also add gating for the strings as well.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by apacible@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2163753003/#ps40001 (title: "Gate privacy note for official branded browsers.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Md Feedback] Add the rest of existing strings. This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow. The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign. No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog. BUG=615535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d Cr-Commit-Position: refs/heads/master@{#407636} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d Cr-Commit-Position: refs/heads/master@{#407636} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
