chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 69ce1765bc33b7931b4c9ee80775522d31825436..4e0d2402dc72151fea09ad516513dbe906c5ee74 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -7769,6 +7769,23 @@ Keep your key file in a safe place. You will need it to create new versions of y
       <message name="IDS_MD_FEEDBACK_SEND_REPORT_BUTTON" desc="Text for Send Report button of the feedback dialog. When clicked, the feedback report will be sent.">
         Send feedback
       </message>
+      <message name="IDS_MD_FEEDBACK_SCREENSHOT_LABEL" desc="Label for the checkbox to indicate whether the shown screenshot should be included in the feedback report.">
+        Include this screenshot:
+      </message>
+      <message name="IDS_MD_FEEDBACK_SEND_SYSTEM_INFO_LABEL" desc="Label for the checkbox to indicate whether the system info should be included in the feedback report.">
+        Send system information
+      </message>
+      <message name="IDS_MD_FEEDBACK_PRIVACY_NOTE" desc="Text for the privacy note shown on the feedback dialog.">
+        Your Chrome and operating system version will be submitted in addition

[Dan Beam, 2016/07/19 22:13:58]

this mentioned the product name, and therefore should be in
{chromium,google_chrome}_strings.grd

[apacible, 2016/07/20 02:07:49]

This string is only used in chrome branded builds.
{chromium,google_chrome}_strings.grd appear to replace each other depending on
the build branding. I was following the implementation for the current privacy
note:
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=7717

Is there a better place than here and the aforementioned .grd files?

+        to any information you choose to include above. If you include your email
+        address, Google may contact you regarding your feedback report. This feedback
+        is used to diagnose problems and help improve Chrome. Any personal information
+        you submit, whether explicitly or incidentally will be protected in
+        accordance with our privacy policies.<ph name="BEGIN_BOLD">&lt;strong&gt;

[Dan Beam, 2016/07/19 22:13:58]

why are you using <ph> here?  maybe this should be a separate <message>?

[apacible, 2016/07/20 02:07:49]

This follows the pattern for the other strings that have partial styling -- i.e.
bold. There's some other examples in this file, e.g.
IDS_CAPTIVE_PORTAL_PRIMARY_PARAGRAPH_WIRED.

+        </ph> By submitting this feedback, you agree that Google may use feedback
+        that you provide to improve any Google product or service.
+        <ph name="END_BOLD">&lt;/strong&gt;</ph>
+      </message>
 
       <!-- Clear Browsing Data -->
       <message name="IDS_CLEAR_BROWSING_DATA_TITLE" desc="Dialog title">