Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2163693002: [Merge M-53] Credit card editor for PaymentRequest UI. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M-53] Credit card editor for PaymentRequest UI. When user taps on an incomplete autofill credit card or [+ ADD CARD] button, the card editor launches. For server cards, the editor shows uneditable card information and lets the user set the billing address. For local cards, the editor shows the following fields. 1) A list of icons for supported card types. 2) The card number input with Luhn validation and formatting. Required field. 3) The name on card input. Required field. 4) The month and year dropdowns. January of this year by default for new cards. 5) The billing address dropdown with only complete addresses on disk and an option to add a new address. Required field. 6) A checkbox for saving the new card on disk. Checked by default, so it behaves similar to autofill settings. BUG=624924 Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea Review-Url: https://codereview.chromium.org/2116583002 Cr-Original-Commit-Position: refs/heads/master@{#405876} Cr-Commit-Position: refs/heads/master@{#406036} (cherry picked from commit 80b5895d9b722eba9129c62c1788f8cbef351dc4) Committed: https://chromium.googlesource.com/chromium/src/+/fd5f99f58ab6cc260f78f9b07d530181bac71b59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1955 lines, -451 lines) Patch
A chrome/android/java/res/drawable-hdpi/pr_dinersclub.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/pr_jcb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/pr_unionpay.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/pr_dinersclub.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/pr_jcb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/pr_unionpay.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/pr_dinersclub.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/pr_jcb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/pr_unionpay.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/pr_dinersclub.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/pr_jcb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/pr_unionpay.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/pr_dinersclub.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/pr_jcb.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/pr_unionpay.png View Binary file 0 comments Download
M chrome/android/java/res/layout/payment_request_editor_dropdown.xml View 1 chunk +4 lines, -4 lines 0 comments Download
A chrome/android/java/res/layout/payment_request_editor_icons.xml View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/payment_request_editor_label.xml View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/ids.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 10 chunks +53 lines, -44 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 5 chunks +33 lines, -30 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 6 chunks +71 lines, -29 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +543 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 17 chunks +62 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 5 chunks +33 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 7 chunks +203 lines, -34 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java View 1 chunk +61 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java View 6 chunks +42 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 14 chunks +166 lines, -68 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java View 2 chunks +27 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 6 chunks +17 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Validatable.java View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java View 2 chunks +0 lines, -92 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java View 1 chunk +99 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 3 chunks +19 lines, -28 lines 0 comments Download
M chrome/android/java_sources.gni View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java View 3 chunks +2 lines, -16 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 7 chunks +98 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 9 chunks +90 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java View 1 chunk +15 lines, -10 lines 0 comments Download
M chrome/browser/android/resource_id.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 4 chunks +40 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 7 chunks +72 lines, -6 lines 0 comments Download
M chrome/test/data/android/payments/no_shipping.js View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/payments/full_card_request.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/payments/full_card_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill_strings.grdp View 1 chunk +7 lines, -7 lines 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 5 months ago (2016-07-19 16:43:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd5f99f58ab6cc260f78f9b07d530181bac71b59.

Powered by Google App Engine
This is Rietveld 408576698