Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/third_party.gni

Issue 2163653002: GN: refactor third_party/gni (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fmt Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/BUILD.gn ('k') | third_party/zlib/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/third_party.gni
diff --git a/third_party/third_party.gni b/third_party/third_party.gni
index 813ee385f3b192cf8cf6be0c3cfba5bf13545f95..ede698c4afafd3e7d597b17edcfa44cb7fa82e69 100644
--- a/third_party/third_party.gni
+++ b/third_party/third_party.gni
@@ -3,13 +3,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-declare_args() {
-}
+template("third_party") {
+ source_set(target_name) {
+ forward_variables_from(invoker, "*")
+
+ # Warnings are just noise if we're not maintaining the code.
+ cflags = [ "-w" ]
-# Chrome's GN environment sets up a bunch of default configs we don't need/want here.
-unwanted_configs = [
- "//build/config/clang:extra_warnings",
- "//build/config/clang:find_bad_constructs",
- "//build/config/compiler:chromium_code",
- "//build/config:feature_flags",
-]
+ # Chrome's GN environment sets up a bunch of default configs we don't need/want here.
+ configs -= [
+ "//build/config/clang:extra_warnings",
+ "//build/config/clang:find_bad_constructs",
+ "//build/config/compiler:chromium_code",
+ "//build/config:feature_flags",
+ ]
+ }
+}
« no previous file with comments | « third_party/BUILD.gn ('k') | third_party/zlib/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698