Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: third_party/BUILD.gn

Issue 2163653002: GN: refactor third_party/gni (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fmt Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/third_party.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/BUILD.gn
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index 96837d2b3a89aa79ab75ef5a26376a985ec99d62..1aca3ca9cbf494d8e7d63611df11664b79ad9130 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -3,24 +3,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("third_party.gni")
-
-# Most third_party code should disable warnings: if we don't maintain the code, warnings are noise.
-config("no_warnings") {
- cflags = [ "-w" ]
+declare_args() {
}
-third_party_configs = [ ":no_warnings" ]
+
+import("third_party.gni")
config("libpng_public") {
include_dirs = [ "libpng" ]
}
-source_set("libpng") {
+third_party("libpng") {
public_configs = [ ":libpng_public" ]
- configs += third_party_configs
- configs -= unwanted_configs
deps = [
- ":zlib",
+ "//third_party/zlib",
]
sources = [
"libpng/png.c",
@@ -44,10 +39,8 @@ source_set("libpng") {
config("libjpeg-turbo_config") {
include_dirs = [ "externals/libjpeg-turbo" ]
}
-source_set("libjpeg-turbo") {
+third_party("libjpeg-turbo") {
public_configs = [ ":libjpeg-turbo_config" ]
- configs += third_party_configs
- configs -= unwanted_configs
sources = [
"externals/libjpeg-turbo/jcapimin.c",
« no previous file with comments | « no previous file | third_party/third_party.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698