Linux: Build with xcb (Reland)

ui/gfx/x/x11_types.cc

Index: ui/gfx/x/x11_types.cc
diff --git a/ui/gfx/x/x11_types.cc b/ui/gfx/x/x11_types.cc
index 7540f8ae2887cbcdcebf09982790a8a8ba797314..cb8b630b9d72de1e7a34eb6d7967aefcd8e4d24c 100644
--- a/ui/gfx/x/x11_types.cc
+++ b/ui/gfx/x/x11_types.cc
@@ -5,6 +5,8 @@
 #include "ui/gfx/x/x11_types.h"
 
 #include <X11/Xlib.h>
+#include <xcb/xcb.h>
+#include <X11/Xlib-xcb.h>
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
@@ -14,6 +16,10 @@
 namespace gfx {
 
 XDisplay* GetXDisplay() {
+  // TODO(thomasanderson): remove these symbol references once libxcb and
+  // libX11-xcb are used
+  asm volatile("" ::"r"(xcb_connect));

[Tom (Use chromium acct), 2016/08/03 19:42:16]

Couldn't figure out a better way to do this

[sadrul, 2016/08/04 15:45:29]

What does this do?

[Tom (Use chromium acct), 2016/08/04 16:32:53]

References symbols so we link against the shared libraries and the dependencies
show up in expected_build_deps.

I wanted all of the build stuff to go in one cl, but maybe the
expected_build_deps stuff should just go in the next one that actually uses xcb?

+  asm volatile("" ::"r"(XGetXCBConnection));
   static XDisplay* display = NULL;
   if (!display)
     display = OpenNewXDisplay();
@@ -173,4 +179,3 @@ void PutARGBImage(XDisplay* display,
 }
 
 }  // namespace gfx
-

[Tom (Use chromium acct), 2016/08/03 19:42:16]

emacs auto-saves the file like this