Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: nacl/dyn-link/ldscripts/elf64_nacl.x.static

Issue 21636003: Add a PT_NOTE section to mark build_id. (Closed) Base URL: http://git.chromium.org/native_client/nacl-glibc.git@master
Patch Set: fix trybots Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: nacl/dyn-link/ldscripts/elf64_nacl.x.static
diff --git a/nacl/dyn-link/ldscripts/elf64_nacl.x.static b/nacl/dyn-link/ldscripts/elf64_nacl.x.static
index e5840b7c2eac7acb34dcc5805911aca99544f9d6..01b261bd35ba8c922b443dc223047fd0c1b2e8b9 100644
--- a/nacl/dyn-link/ldscripts/elf64_nacl.x.static
+++ b/nacl/dyn-link/ldscripts/elf64_nacl.x.static
@@ -17,6 +17,7 @@ PHDRS
seg_rodata PT_LOAD FLAGS(4) ; /* read */
seg_tls PT_TLS FLAGS(4) ;
seg_rwdata PT_LOAD FLAGS(6) ; /* read + write */
+ seg_note PT_NOTE FLAGS(4) ;
}
SECTIONS
{
@@ -50,8 +51,9 @@ SECTIONS
PROVIDE_HIDDEN (__note_gnu_build_id_start = .);
*(.note.gnu.build-id)
PROVIDE_HIDDEN (__note_gnu_build_id_end = .);
- } :seg_rodata
- .hash : { *(.hash) }
+ } :seg_rodata :seg_note
+ .dummy : {} :seg_rodata
+ .hash : { *(.hash) }
Mark Seaborn 2013/08/07 16:43:07 Don't add space at end of line here
bradn 2013/08/07 18:30:02 Done.
.gnu.hash : { *(.gnu.hash) }
.dynsym : { *(.dynsym) }
.dynstr : { *(.dynstr) }

Powered by Google App Engine
This is Rietveld 408576698