Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: nacl/dyn-link/ldscripts/elf64_nacl.x

Issue 21636003: Add a PT_NOTE section to mark build_id. (Closed) Base URL: http://git.chromium.org/native_client/nacl-glibc.git@master
Patch Set: fix trybots Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: nacl/dyn-link/ldscripts/elf64_nacl.x
diff --git a/nacl/dyn-link/ldscripts/elf64_nacl.x b/nacl/dyn-link/ldscripts/elf64_nacl.x
index 927cf874907b3a665caf04bb482dc7a3f2b349c8..63bb3bc9f84fa7fd31034b1ac1624a36415760b1 100644
--- a/nacl/dyn-link/ldscripts/elf64_nacl.x
+++ b/nacl/dyn-link/ldscripts/elf64_nacl.x
@@ -14,6 +14,7 @@ PHDRS
seg_dynamic PT_DYNAMIC FLAGS(6) ;
seg_stack PT_GNU_STACK FLAGS(6) ;
seg_tls PT_TLS FLAGS(4) ;
+ seg_note PT_NOTE FLAGS(4) ;
}
SECTIONS
{
@@ -52,7 +53,8 @@ SECTIONS
PROVIDE_HIDDEN (__note_gnu_build_id_start = .);
*(.note.gnu.build-id)
PROVIDE_HIDDEN (__note_gnu_build_id_end = .);
- } :seg_rodata
+ } :seg_rodata :seg_note
+ .dummy : {} : seg_rodata
Mark Seaborn 2013/08/07 16:43:07 Make this line up with below? Add spaces before f
bradn 2013/08/07 18:30:02 Done.
.hash : { *(.hash) }
.gnu.hash : { *(.gnu.hash) }
.dynsym : { *(.dynsym) }

Powered by Google App Engine
This is Rietveld 408576698