MD Settings: re-enable settings translations ONCE AND FOR ALL

MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145, 627474
TBR=dpranke@chromium.org  # for tools/OWNERS

Committed: https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed
Cr-Commit-Position: refs/heads/master@{#406654}

[Dan Beam, 2016-07-19 23:43:37]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-07-19 23:45:04]

agable@: am I doin it rite?

thestig@: I'll add you for OWNERS when agable@'s done.

https://codereview.chromium.org/2163543004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc (left):

https://codereview.chromium.org/2163543004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc:29: #include
"chrome/grit/chromium_strings.h"
unused (also... doesn't include google_chrome_strings GIVEAWAY)

[Dan Beam, 2016-07-19 23:45:16]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 23:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agable, 2016-07-19 23:49:53]

I know how literally none of the internationalization actually works, I just
know how to shuttle xml files from chromium/src into the transconsole and the
results back again :) If there are syntax errors in your .grd(p) files, I won't
be the one to catch them.

[Dan Beam, 2016-07-19 23:50:47]

Description was changed from

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=agable@chromium.org
BUG=629145,627474
==========

to

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474
==========

[Dan Beam, 2016-07-19 23:50:47]

dbeam@chromium.org changed reviewers:
+ thestig@chromium.org
- agable@chromium.org

[Dan Beam, 2016-07-19 23:51:07]

On 2016/07/19 23:49:53, agable wrote:
> I know how literally none of the internationalization actually works, I just
> know how to shuttle xml files from chromium/src into the transconsole and the
> results back again :) If there are syntax errors in your .grd(p) files, I
won't
> be the one to catch them.

very well! thestig@'s on the hook earlier than anticipated.

[Lei Zhang, 2016-07-19 23:54:20]

https://codereview.chromium.org/2163543004/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (left):

https://codereview.chromium.org/2163543004/diff/20001/chrome/BUILD.gn#oldcode...
chrome/BUILD.gn:1648: "//chrome/app:settings_chromium_strings",
These weren't in alphabetical order anyway. :-P

[Lei Zhang, 2016-07-19 23:59:36]

lgtm

[Dan Beam, 2016-07-20 00:01:36]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:03:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:13:47]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-07-20 19:08:18]

Description was changed from

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474
==========

to

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474

TBR=dpranke@chromium.org  # for tools/OWNERS
==========

[Dan Beam, 2016-07-20 19:08:29]

dbeam@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dan Beam, 2016-07-20 19:09:05]

TBR=dpranke@ for tools/OWNERS

[Dan Beam, 2016-07-20 19:09:11]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 20:22:33]

Description was changed from

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474

TBR=dpranke@chromium.org  # for tools/OWNERS
==========

to

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474

TBR=dpranke@chromium.org  # for tools/OWNERS
==========

[commit-bot: I haz the power, 2016-07-20 20:22:34]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-20 20:24:26]

Description was changed from

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474

TBR=dpranke@chromium.org  # for tools/OWNERS
==========

to

==========
MD Settings: re-enable settings translations ONCE AND FOR ALL

R=thestig@chromium.org
BUG=629145,627474

TBR=dpranke@chromium.org  # for tools/OWNERS

Committed: https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed
Cr-Commit-Position: refs/heads/master@{#406654}
==========

[commit-bot: I haz the power, 2016-07-20 20:24:28]

Patchset 3 (id:??) landed as
https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed
Cr-Commit-Position: refs/heads/master@{#406654}

[Dirk Pranke, 2016-07-20 21:29:38]

lgtm